Context Navigation

Modify ↓

#7076 closed defect (fixed)

[patch] Treat RTF files with .doc extension as binary

Reported by:	uws@…	Owned by:	Thijs Triemstra
Priority:	high	Milestone:	0.12.2
Component:	attachment	Version:	0.11-stable
Severity:	minor	Keywords:	msword, patch
Cc:	Thijs Triemstra	Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Thijs Triemstra)

Some .doc files have an application/rdf mime type, e.g. Abiword export-as-doc actually saves a RTF file with a .doc filename. These files are not handled correctly by the Trac MIME viewer, since those RTF files are incorrectly shown as text. The special handling code for RTF (and PostScript and PDF) does not catch this case.

The fix is quite simple:

Detect .doc and .dot files as application/msword
Add application/msword to the TREAT_AS_BINARY list

Trivial patch below:

trac/mimeview/api.py

-              old
+              new
     'application/pdf':        ['pdf'],
     'application/postscript': ['ps'],
     'application/rtf':        ['rtf'],
+    'application/msword':     ['doc', 'dot'],
     'application/x-sh':       ['sh'],
     'application/x-csh':      ['csh'],
     'application/x-troff':    ['nroff', 'roff', 'troff'],
 …
     TREAT_AS_BINARY = [
         'application/pdf',
         'application/postscript',
+        'application/rtf'
+        'application/rtf',
+        'application/msword',
+    ]
     def get_quality_ratio(self, mimetype):

Please include this in your upcoming releases.

Sincerely,

Wouter Bolsterlee <uws@…>

Attachments (1)

msword.patch (843 bytes ) - added by Thijs Triemstra 13 years ago.: updated patch against 0.12 stable

Download all attachments as: .zip

Change History (16)

comment:1 by Christian Boos, 16 years ago

Component:	general → rendering
Keywords:	msword added
Milestone:	→ 0.11.1
Owner:	changed from Jonas Borgström to Christian Boos
Severity:	normal → minor
Status:	new → assigned

Looks good, thanks.

comment:2 by Wouter Bolsterlee, 16 years ago

Any chance this gets committed any time soon? It's a trivial patch and would help a lot of users (hopefully).

comment:3 by anonymous, 16 years ago

Component:	rendering → attachment
Version:	0.10.4 → 0.11-stable

comment:4 by Wouter Bolsterlee, 16 years ago

(Forgot to fill in my name, previous anonymous changes were by me.)

comment:5 by Christian Boos, 15 years ago

Milestone:	0.11-retriage → 0.11.5

comment:6 by Christian Boos, 15 years ago

Milestone:	0.11.6 → 0.12.1

by Thijs Triemstra, 13 years ago

Attachment:	msword.patch added

updated patch against 0.12 stable

comment:7 by Thijs Triemstra, 13 years ago

Cc:	Thijs Triemstra added
Keywords:	patch added
Milestone:	next-minor-0.12.x → 0.12.2

comment:8 by Remy Blank, 13 years ago

Owner:	changed from Christian Boos to Remy Blank
Priority:	normal → high
Status:	assigned → new

Thanks for the update, I'll apply the patch.

comment:9 by uws@…, 13 years ago

Wow, finally some activity on this bug after ~30 months! I totally forgot about this, but feel a bit sad now that I it has bitrotted for so long. Sigh.

<sarcasm>Well done! This really encourages people to contribute to the project!</sarcasm>

— Wouter Bolsterlee

comment:10 by Thijs Triemstra, 13 years ago

With 900+ tickets out there stuff sometimes gets lots I guess :)

follow-up: 12 comment:11 by uws@…, 13 years ago

Sure, but somehow in Gnome Bugzilla or Launchpad I have never seen well-described issues with patches get lost for so long… so this is still a project problem imho.

in reply to: 11 comment:12 by Thijs Triemstra, 13 years ago

Replying to uws@…:

Sure, but somehow in Gnome Bugzilla or Launchpad I have never seen well-described issues with patches get lost for so long… so this is still a project problem imho.

I've been going through tickets for a few weeks now, and out of the 900 tickets I found 1 other 'stray' ticket like this (#6289). I wouldn't call it a 'project problem'. Thanks for the patch!

comment:13 by Remy Blank, 13 years ago

Resolution:	→ fixed
Status:	new → closed

Patch applied in [10367].

comment:14 by Remy Blank, 13 years ago

Owner:	changed from Remy Blank to Thijs Triemstra

comment:15 by Thijs Triemstra, 13 years ago

Description:	modified (diff)

Modify Ticket

Change Properties

Summary:
Description:	Some .doc files have an {{{application/rdf}}} mime type, e.g. Abiword export-as-doc actually saves a RTF file with a .doc filename. These files are not handled correctly by the Trac MIME viewer, since those RTF files are incorrectly shown as text. The special handling code for RTF (and !PostScript and PDF) does not catch this case. The fix is quite simple: * Detect .doc and .dot files as {{{application/msword}}} * Add {{{application/msword}}} to the {{{TREAT_AS_BINARY}}} list Trivial patch below: {{{ #!diff --- trac/mimeview/api.py.orig 2008-04-03 23:24:33.000000000 +0200 +++ trac/mimeview/api.py 2008-04-03 23:24:40.000000000 +0200 @@ -76,6 +76,7 @@ 'application/pdf': ['pdf'], 'application/postscript': ['ps'], 'application/rtf': ['rtf'], + 'application/msword': ['doc', 'dot'], 'application/x-sh': ['sh'], 'application/x-csh': ['csh'], 'application/x-troff': ['nroff', 'roff', 'troff'], @@ -674,7 +675,8 @@ TREAT_AS_BINARY = [ 'application/pdf', 'application/postscript', - 'application/rtf' + 'application/rtf', + 'application/msword', ] def get_quality_ratio(self, mimetype): }}} Please include this in your upcoming releases. Sincerely, Wouter Bolsterlee <uws@xs4all.nl> You may use WikiFormatting here.
Type:		Priority:
Milestone:		Component:
Version:		Severity:
Keywords:		Cc:	Set your email in Preferences
Branch:
Release Notes:
API Changes:
Internal Changes:

Action

leave as closed The owner will remain Thijs Triemstra.

reopen The resolution will be deleted. Next status will be 'reopened'.

change ownership to The owner will be changed from Thijs Triemstra to the specified user.

Add Comment

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.

Download in other formats: