[PATCH] Incorrect priorities in iCal roadmap format

[Trevor MacPhail <trevor@…>]

Priorities in an iCal file are supposed to range from 1(highest) to 9(lowest). The current output of an iCal roadmap only generates this range if there are exactly 9 priorities.

If there are, for example, 3 priorities, the possible output values are 3,6, and 9. This means that priority 2(presumably 'normal' priority) in trac will output and display as 6(slightly lower than normal). And if there are more than 9, then one or more of the highest priorities gets output as 0.

I've attached a patch which causes the range to always be from 1 to 9 and the median priority will always output 5. If there is an even number of priorities, then there is no median, but the closest value under the median should get truncated to 5 after division if there are enough priorities.

[Christian Boos]

Thanks for the patch.

[osimons]

I'll put it on my todo.

[Thijs Triemstra <lists@…>]

updated patch against stable-0.12 r10174

[Thijs Triemstra <lists@…>]

I attached an updated patch, tested with ical on osx 10.6 and the priorities are now fixed (with a vanilla trac installation). Moving it to 0.12.2 cause this looks like a minor ticket and it's way overdue:)

[Christian Boos]

Simon, do you still want to take care of this one?

[osimons]

Sure, thanks for the reminder. Patch looks good, so I'll test and commit.

[osimons]

Committed in [10245:10246] for 0.12 and trunk. Thanks for your patience ;-)