ImportError: No module named neo_cs

[hzzhu]

How to Reproduce

While doing a GET operation on /admin/accounts/config, Trac issued an internal error.

(please provide additional details here)

Request parameters:

{'cat_id': u'accounts', 'panel_id': u'config', 'path_info': None}

User Agent was: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; zh-cn) AppleWebKit/525.13 (KHTML, like Gecko) Version/3.1 Safari/525.13

System Information

Trac	0.11b2
Python	2.5.2 (r252:60911, Mar 31 2008, 12:55:29) [GCC 4.1.1 20070105 (Red Hat 4.1.1-52)]
setuptools	0.6c8
SQLite	3.3.17
pysqlite	2.4.1
mod_python	3.3.1
Genshi	0.4.4
Pygments	0.9
jQuery:	1.2.3

Python Traceback

Traceback (most recent call last):
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11b2-py2.5.egg/trac/web/main.py", line 419, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11b2-py2.5.egg/trac/web/main.py", line 196, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11b2-py2.5.egg/trac/admin/web_ui.py", line 116, in process_request
    output = req.hdf.render(cstmpl)
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11b2-py2.5.egg/trac/web/clearsilver.py", line 302, in render
    import neo_cs
ImportError: No module named neo_cs

[Christian Boos]

That ImportError should be converted to a clearer TracError, something like:

trac/web/clearsilver.py

@@ -299 +299 @@
         """
         if isinstance(template, basestring):
             filename = template
-            import neo_cs
+            try:
+                import neo_cs
+            except ImportError:
+                raise TracError("You're using a plugin which requires "
+                                "the Clearsilver template engine and "
+                                "Clearsilver is not installed. "
+                                "Either disable that plugin or install "
+                                "Clearsilver.")
             template = neo_cs.CS(self.hdf)
             template.parseFile(filename)
 

[osimons]

Good idea. +1.

[Jeroen Ruigrok van der Werven]

Fine by me.

[Christian Boos]

Applied in r6822.