Zip Archives created with Trac/python2.5 have bad file attributes

[hvr]

see also ​th:ticket:2602

this issue doesn't show up with python 2.4, since there zipfile defaults to setting the create_system field to DOS always, but with 2.5 this changed to

/usr/lib/python2.

@@ -1 @@
-        self.create_system = 0          # System which created ZIP archive
+        if sys.platform == 'win32':
+            self.create_system = 0          # System which created ZIP archive
+        else:
+            # Assume everything else is unix-y
+            self.create_system = 3          # System which created ZIP archive

basically to fix this, Trac should set ZipInfo external_attr and/or create_system fields apropriately, to avoid

[Christian Boos]

See also ​PythonBug:1412872 for more background.

[Christian Boos]

Fixed in [6558], thanks for the report and the hint given for fixing it.

[hvr]

just wondering, with changeset:6558 for the case of python 2.4, it sets some external_attr that might not be sensible for the default create_system=0… shouldn't we explicitly set create_system=3 as well to be on the safe side?

[Christian Boos]

I think it's OK like that. If you look at the implementation of ​ZipFile.write(), you'll see that the upper 16 bits of the external_attr attribute (dubbed "Unix attributes") are always set, regardless of the value of create_system attribute.