Opened 20 years ago
Closed 20 years ago
#683 closed enhancement (fixed)
[merge]add save/preview/cancel on bottom of preview pages
| Reported by: | Owned by: | utopiste | |
|---|---|---|---|
| Priority: | high | Milestone: | 0.9 |
| Component: | wiki system | Version: | 0.7.1 |
| Severity: | normal | Keywords: | |
| Cc: | toni.brkic@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
I think that there should also be add/edit buttons on top of wikipages not only on the bottom of the page.
And also save/preview/cancel on bottom of pages when editing wikipages.
I can implement if it is considering a good enhancement and that it will be merged in if I do it.
/Toni
Attachments (6)
Change History (20)
comment:1 by , 20 years ago
comment:2 by , 20 years ago
| Summary: | add edit and attach on top of page on wikipages → [merge]add save/preview/cancel on bottom of preview pages |
|---|
After discussion with Jonas. I've implemented to have save/preview/cancel buttons when editing a wikipage. But not the other buttons.
I have also added so that you get the text 'draft' as background picture when doing preview. So that you dont forget to do save. It has happened to me a couple of times. The idea and picture is taken from moin-moin wiki. It is alos GPL so is no problem to use.
This patch also includes fix for #660.
Best regards,
Toni
by , 20 years ago
| Attachment: | patch_draft_and_remeber_pos.2.diff added |
|---|
Correct patch including all wiki.cs changes
by , 20 years ago
| Attachment: | patch_draft_and_remeber_pos.3.diff added |
|---|
Modified according to Jonas comments. Minor fixes.
comment:4 by , 20 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
This patch seems to break wiki saving after using preview, see #752.
by , 20 years ago
| Attachment: | patch_683.diff added |
|---|
Fixed problems with old solution.Solution with javascript.
comment:5 by , 20 years ago
| Owner: | changed from to |
|---|---|
| Status: | reopened → new |
comment:6 by , 20 years ago
| Milestone: | → 0.8 |
|---|---|
| Priority: | normal → high |
Looks like applying the patch has broken something (see previous comments). So we'll need to fix that for 0.8.
comment:7 by , 20 years ago
Fixed what was broken. See the patch_683.diff. This is a javascript solution where the buttons on button call the method in the form.
comment:8 by , 20 years ago
| Milestone: | 0.8 → 0.9 |
|---|
comment:9 by , 20 years ago
| Milestone: | 0.9 → 0.8.1 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
merged in [1188]
comment:10 by , 20 years ago
| Milestone: | 0.8.1 → 0.9 |
|---|
comment:11 by , 20 years ago
I have backed out this change. The preview is now above the <textarea>, so actually I don't think the duplication of form controls is needed anymore.
comment:12 by , 20 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
If the preview is below I think that the buttons should be duplicated at the top. The idea of the buttons is that one should be able to submit the wikipage both at the top and bottom. So if you have a long wiki page you dont need to scroll very far to be able to submit it.
/T
comment:13 by , 20 years ago
There's an anchor at the start of the preview that let's you jump to the <textarea>.
comment:14 by , 20 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
I havent upgraded trunk in a long time. As it is now it is much better than duplicate the buttons. Sorry the comment without checking how it was implemented.
The only addittional comment I have is that I dont think 'skip' is such a good name. But I dont have any better idea either.
/T
test add comment