Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

#683 closed enhancement (fixed)

[merge]add save/preview/cancel on bottom of preview pages

Reported by: toni.brkic@… Owned by: utopiste
Priority: high Milestone: 0.9
Component: wiki system Version: 0.7.1
Severity: normal Keywords:
Cc: toni.brkic@… Branch:
Release Notes:
API Changes:

Description

I think that there should also be add/edit buttons on top of wikipages not only on the bottom of the page.

And also save/preview/cancel on bottom of pages when editing wikipages.

I can implement if it is considering a good enhancement and that it will be merged in if I do it.

/Toni

Attachments (6)

patch_draft_and_remeber_pos.diff (3.9 KB ) - added by tonib 15 years ago.
patch for the ticket
draft.png (4.7 KB ) - added by tonib 15 years ago.
draft picture to be placed in htdocs
patch_draft_and_remeber_pos.2.diff (7.0 KB ) - added by tonib 15 years ago.
Correct patch including all wiki.cs changes
patch_draft_and_remeber_pos.3.diff (6.6 KB ) - added by tonib 15 years ago.
Modified according to Jonas comments. Minor fixes.
patch_683.diff (3.1 KB ) - added by tonib 15 years ago.
Fixed problems with old solution.Solution with javascript.
patch_683.2.diff (3.8 KB ) - added by tbrkic 15 years ago.
Updated so that it work against r996

Download all attachments as: .zip

Change History (20)

comment:1 by anonymous, 15 years ago

test add comment

comment:2 by tonib, 15 years ago

Summary: add edit and attach on top of page on wikipages[merge]add save/preview/cancel on bottom of preview pages

After discussion with Jonas. I've implemented to have save/preview/cancel buttons when editing a wikipage. But not the other buttons.

I have also added so that you get the text 'draft' as background picture when doing preview. So that you dont forget to do save. It has happened to me a couple of times. The idea and picture is taken from moin-moin wiki. It is alos GPL so is no problem to use.

This patch also includes fix for #660.

Best regards,

Toni

by tonib, 15 years ago

patch for the ticket

by tonib, 15 years ago

Attachment: draft.png added

draft picture to be placed in htdocs

by tonib, 15 years ago

Correct patch including all wiki.cs changes

by tonib, 15 years ago

Modified according to Jonas comments. Minor fixes.

comment:3 by Jonas Borgström, 15 years ago

Resolution: fixed
Status: newclosed

Patch applied, thanks!

comment:4 by Jonas Borgström, 15 years ago

Resolution: fixed
Status: closedreopened

This patch seems to break wiki saving after using preview, see #752.

by tonib, 15 years ago

Attachment: patch_683.diff added

Fixed problems with old solution.Solution with javascript.

comment:5 by utopiste, 15 years ago

Owner: changed from Jonas Borgström to utopiste
Status: reopenednew

comment:6 by Christopher Lenz, 15 years ago

Milestone: 0.8
Priority: normalhigh

Looks like applying the patch has broken something (see previous comments). So we'll need to fix that for 0.8.

comment:7 by tonib, 15 years ago

Fixed what was broken. See the patch_683.diff. This is a javascript solution where the buttons on button call the method in the form.

comment:8 by daniel, 15 years ago

Milestone: 0.80.9

by tbrkic, 15 years ago

Attachment: patch_683.2.diff added

Updated so that it work against r996

comment:9 by utopiste, 15 years ago

Milestone: 0.90.8.1
Resolution: fixed
Status: newclosed

merged in [1188]

comment:10 by Christopher Lenz, 15 years ago

Milestone: 0.8.10.9

comment:11 by Christopher Lenz, 15 years ago

I have backed out this change. The preview is now above the <textarea>, so actually I don't think the duplication of form controls is needed anymore.

comment:12 by anonymous, 15 years ago

Resolution: fixed
Status: closedreopened

If the preview is below I think that the buttons should be duplicated at the top. The idea of the buttons is that one should be able to submit the wikipage both at the top and bottom. So if you have a long wiki page you dont need to scroll very far to be able to submit it.

/T

comment:13 by Christopher Lenz, 15 years ago

There's an anchor at the start of the preview that let's you jump to the <textarea>.

comment:14 by anonymous, 15 years ago

Resolution: fixed
Status: reopenedclosed

I havent upgraded trunk in a long time. As it is now it is much better than duplicate the buttons. Sorry the comment without checking how it was implemented.

The only addittional comment I have is that I dont think 'skip' is such a good name. But I dont have any better idea either.

/T

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain utopiste.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from utopiste to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.