Oops when browsing code

[anonymous]

I was just browsing my code and got this error. It seems that this happens when accessing a directory for which I declared an svn:external property.

Trac detected an internal error:

TypeError: an integer is required

Python Traceback :

File "c:\python25\lib\site-packages\Trac-0.11b1-py2.5-win32.egg\trac\web\main.py", line 398, in _dispatch_request
  dispatcher.dispatch(req)
File "c:\python25\lib\site-packages\Trac-0.11b1-py2.5-win32.egg\trac\web\main.py", line 195, in dispatch
  resp = chosen_handler.process_request(req)
File "c:\python25\lib\site-packages\Trac-0.11b1-py2.5-win32.egg\trac\versioncontrol\web_ui\browser.py", line 358, in process_request
  node.get_properties()),
File "c:\python25\lib\site-packages\Trac-0.11b1-py2.5-win32.egg\trac\versioncontrol\web_ui\browser.py", line 542, in render_properties
  for name in props])
File "c:\python25\lib\site-packages\Trac-0.11b1-py2.5-win32.egg\trac\versioncontrol\web_ui\browser.py", line 553, in render_property
  rendered = renderer.render_property(name, mode, context, props)
File "c:\python25\lib\site-packages\Trac-0.11b1-py2.5-win32.egg\trac\versioncontrol\svn_fs.py", line 310, in render_property
  return self._render_externals(props[name])
File "c:\python25\lib\site-packages\Trac-0.11b1-py2.5-win32.egg\trac\versioncontrol\svn_fs.py", line 349, in _render_externals
  href % {'path': remotepath, 'rev': rev}))

System Information:

User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Trac: 	0.11b1
Python: 	2.5.1 (r251:54863, Apr 18 2007, 08:51:08) [MSC v.1310 32 bit (Intel)]
setuptools: 	0.6c7
SQLite: 	3.3.4
pysqlite: 	2.3.2
Genshi: 	0.5dev-r789
Pygments: 	0.9
Subversion: 	1.4.6 (r28521)
jQuery:	1.2.1

[Christian Boos]

Can you show us the value of that property (svn pget svn:externals <thepath>)?

[anonymous]

Replying to cboos:

Can you show us the value of that property (svn pget svn:externals <thepath>)?

Here is :

embedded http://serv-be.thcg.net/svn/Legendair/LEGENDAIR%20XL2/ETUDE%20SOFT/Sources/CPU/trunk/SRC/

[Christian Boos]

Ok, probably the %20 in the path, as that will become part of a string used as a format string.

[anonymous]

Replying to cboos:

Ok, probably the %20 in the path, as that will become part of a string used as a format string.

Yes, spaces are converted to %20 and Trac does like this. I'm a bit astonished this has not been reported before…

[Christian Boos]

Well, I admit the [svn:externals] section has been a bit under-tested: I only had two entries (one svn: the other http:, leading to issue #6784 which is much worse than this one), none of those URLs containing spaces…

But the problem here is easy to fix (s/%/%%/g at the appropriate place in the renderer).

[Christian Boos]

Should be fixed in [6504].