Edgewall Software
Modify ↓

Opened 16 years ago

Closed 16 years ago

#6747 closed defect (fixed)

set_owner and set_resolution on a state change in a workflow result in poor formatting

Reported by: mark.m.mcmahon@… Owned by: Jonas Borgström
Priority: low Milestone: 0.11
Component: ticket system Version: devel
Severity: minor Keywords:
Cc: mark.m.mcmahon@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

If you have both a set_resolution and a set_owner for a workflow item e.g. 

decline = open -> declined
decline.operations = set_owner,set_resolution
decline.set_owner = QA
decline.set_resolution = Next Release, Next Main Release, Not A Bug

then you get for the decline action… "decline to QAas" (see image attached)

It was interesting to see that when I cut and pasted from the Browser that there was an extra space between "decline" and "to" (which is not noticable in the rendered page). Because of this the easiest fix would be to just add a space after "to %s" in default_workflow.py (patch attached).

(this was on 0.11dev-r6425)

Attachments (2)

set_owner_and_set_resolution.PNG​ (5.9 KB ) - added by mark.m.mcmahon@… 16 years ago.
Example of poor formatting
space_after_to.diff​ (2.1 KB ) - added by mark.m.mcmahon@… 16 years ago.
patch to add a space after to %s

Download all attachments as: .zip

Change History (3)

by mark.m.mcmahon@…, 16 years ago

Attachment: set_owner_and_set_resolution.PNG​ added

Example of poor formatting

by mark.m.mcmahon@…, 16 years ago

Attachment: space_after_to.diff​ added

patch to add a space after to %s

comment:1 by Eli Carter, 16 years ago

Resolution: → fixed
Status: new → closed

Testcase added to sandbox/testing in [6630].

Fixed in trunk in [6631] and in sandbox/testing in [6632].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.