Hidden fieldsets for custom queries

[Christian Boos]

This is a small cosmetic improvement to the display of fieldsets for custom queries:

1. I think the fieldsets looks prettier without the border when it's folded.
2. For saved queries, I think it's better if the filters fieldset is hidden by default. Indeed, the saved queries can have a pretty long list of conditions, and a short description can often describe the query in a more concise way than a raw list of filters.

As those are cosmetic and UI changes, I ask for some feedback first.

[Christian Boos]

The proposed changes

[Christian Boos]

Whoops, the patch ends with a \ No newline at end of file, which messes up the patch formatter in 0.10.x.

Here's the content (for some reason the enscript fallback works in the wiki but not in the attachment view - 0.10 quirks, nevermind):

trac/ticket/templates/query.html

@@ -14 +14 @@
           $("#groupdesc").enable(this.selectedIndex != 0)
         }).change();
         $("fieldset legend").enableFolding(false);
+        /* Hide the filters for saved queries. */
+        if ( window.location.href.search(/[?&]report=[0-9]+/) != -1 )
+          $("#filters").toggleClass("collapsed");
         /* Hide the columns by default. */
         $("#columns").toggleClass("collapsed");
       });

trac/htdocs/css/report.css

@@ -20 +20 @@
 #query { clear: right }
 #query fieldset, #query fieldset input, #query fieldset select { font-size: 11px }
 #query fieldset { margin-top: 1em }
+#query fieldset.collapsed { border-width: 0 }
 #query .option, #query .option input, #query .option select { font-size: 11px }
 #query .option { float: left; line-height: 2em; margin: .9em 2.5em 0 .5em; padding: 0 0 .1em }
 #query .buttons { float: right; margin-top: .5em }
@@ -114 +115 @@
   vertical-align: middle;
   text-align: center;
   font-size: 85%;
-}
- No newline at end of file
+}

[conny@…]

Perhaps we should instead locate all fieldsets on the page and per default collapse them, when in reports and/or query mode. That way other plugins that provice query options. (I'm primarily thinking of ​th:BatchModifyPlugin.)

Add an option under [query], "always_collapse" that defaults to true, and in addition to that allow one to override that setting on the query string (...&collapse=false).

The motivation for this would be

• You could still keep the current behaviour
• When you go to /query, you can choose to always have the fieldsets hidden and use a default_query if you always end up using the same query most of the time anyway
• When you link to the query module you can have more control over the presentation (you might want to send query links to colleagues that despise enormous HTML forms)

[Christian Boos]

Above patch applied in r6559 and r6570.

As for the request to hide all fieldsets, well, that's outside of the scope of the ticket which was really focusing on what you see first when viewing a saved query.

All I wanted is to get something quite similar to what a regular (sql) report looked like: a brief description of the report and the list of tickets. The filters just went in the way.

For other fieldsets, like those added by plugins, I think it's up to their authors to decide whether they should be initially presented collapsed or not.

[Christian Boos]

Read r6569 in the above instead of r6559. Also, reduce the amount of vertical space in r6621.