Edgewall Software
Modify

Opened 13 years ago

Closed 13 years ago

#6635 closed defect (fixed)

/prefs/datetime should default to server TZ

Reported by: Daniel Kahn Gillmor <dkg-debian.org@…> Owned by: Jeroen Ruigrok van der Werven
Priority: normal Milestone: 0.11
Component: i18n Version: 0.11b1
Severity: normal Keywords: timezone
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

On a trac 0.11b1 setup with pytz installed, when a user goes to set their TZ preferences for the first time (at prefs/datetime), they are confronted with a default choice of Asia/Qatar.

It would be more reasonable if they were given a default choice that matched the server's default time zone.

Attachments (1)

6635-fix.diff (3.0 KB ) - added by Daniel Kahn Gillmor <dkg-debian.org@…> 13 years ago.
Fix to default users to server local time zone if they have no time zone set.

Download all attachments as: .zip

Change History (8)

comment:1 by Daniel Kahn Gillmor <dkg-debian.org@…>, 13 years ago

Probably even simpler to implement: the user could be given an explicit "Server Default" choice which would remove the matching name=tz row in the session_attribute table.

by Daniel Kahn Gillmor <dkg-debian.org@…>, 13 years ago

Attachment: 6635-fix.diff added

Fix to default users to server local time zone if they have no time zone set.

comment:2 by Jeroen Ruigrok van der Werven, 13 years ago

Owner: changed from Jonas Borgström to Jeroen Ruigrok van der Werven
Status: newassigned

comment:3 by Jeroen Ruigrok van der Werven, 13 years ago

Milestone: 0.11

This is indeed annoying, looking into it.

comment:4 by intgr, 13 years ago

I've applied this patch and it seems to work.

But when the user clicks "Save changes" with the setting unchanged ("Default time zone" chosen), it goes right back to Asia/Seoul again.

comment:5 by Jeroen Ruigrok van der Werven, 13 years ago

Component: generali18n

comment:6 by Jeroen Ruigrok van der Werven, 13 years ago

The current patch does indeed have some issues. Need to dig into it…

comment:7 by Jeroen Ruigrok van der Werven, 13 years ago

Resolution: fixed
Status: assignedclosed

Fixed in r6689 with a slightly altered patch and another fix to Trac.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jeroen Ruigrok van der Werven.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jeroen Ruigrok van der Werven to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.