Interface definition of IPreferencePanelProvider appears wrong

[shansen@…]

The interface definition is listed as, in trac.prefs.api

def render_preference_panel(req, panel, path_info):

But all the actual implementations leave off the path_info argument. Doesn't seem to matter except it confused me when I went and was using the interface definition as documentation :)

[osimons]

Looked at it, and I can't find any usage where we expect that path_info to exists. When first changing it, we should also use the same variable name for 'panel' to make it more intuitive.

trac/prefs/api.py

@@ -20 +20 @@
         """Return a list of available preference panels.
         
         The items returned by this function must be tuple of the form
-        `(name, label)`.
+        `(panel, label)`.
         """
 
-    def render_preference_panel(req, panel, path_info):
+    def render_preference_panel(req, panel):
         """Process a request for a preference panel.
         
         This function should return a tuple of the form `(template, data)`,

[osimons]

Applied in [6383].