[PATCH] memory leak in svn_fs.py

[Daniel Wallin <daniel@…>]

There's a reference cycle between SubversionRepository and RealSubversionAuthorizer that isn't collectable because of the __del__ method on SubversionRepository. The attached patch fixes the problem.

[Jeroen Ruigrok van der Werven]

Committed in r6385.

Only just saw that you changed the ticket Christian, sorry, was not trying to get in the way.

[Christian Boos]

Yeah, I was about to test it… I just have to update now instead of patching the file, so it's not really getting in the way ;-)

I'll report back my findings.

[Christian Boos]

There are apparently no memory savings (no visible leak either) with or without, only high but stable memory usage, as usual.

When the repository gets explicitly close()d, this effectively frees the svn objects. The repository object itself might be leaked without the patch, but the impact of this is quite minor and I don't thinkg it explains the high memory usage we're seeing. But it's better to avoid that (probably very minor) leak anyway, so I'm closing the issue.

Anyway, for 0.12, the whole SvnAuthorizer stuff could be easily adapted to the security framework (no user visible changes, only an implementation detail).