Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

#6527 closed defect (fixed)

[patch] Zero width space poorly supported in IE6

Reported by: hyuga <hyugaricdeau@…> Owned by: Christian Boos
Priority: low Milestone: 0.11
Component: version control/browser Version: 0.11b1
Severity: trivial Keywords: expander
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The defect here is of course more with IE than with Trac, but it might be something worth doing something about. By default, IE does not correctly display, or not display as the case may be the zero width space (U+200B) used by the new AJAXy repository browser, causing a box to be displayed next to every folder icon.

This can be worked around by installing East-Asian language support in Windows, and fussing with default fonts, but unfortunately I don't have control over how users' fonts are configured.

A possible solution would be to use a normal nbsp for IE6, which still looks okay, and use a zwsp for the rest of the civilized world.

Attachments (2)

ie6-no-zwsp-r6363.diff (1007 bytes ) - added by hyuga <hyugaricdeau@…> 16 years ago.
A suggested fix to this problem using *sigh* browser detection
expander-nbsp-r6363.patch (1.5 KB ) - added by Christian Boos 16 years ago.
Alternative fix, using &nbsp; for all browsers.

Download all attachments as: .zip

Change History (8)

by hyuga <hyugaricdeau@…>, 16 years ago

Attachment: ie6-no-zwsp-r6363.diff added

A suggested fix to this problem using *sigh* browser detection

comment:1 by hyuga <hyugaricdeau@…>, 16 years ago

Summary: Zero width space poorly supported in IE6[patch] Zero width space poorly supported in IE6

comment:2 by evantdster@…, 16 years ago

Non-breaking spaces and zero-width spaces are basically opposite things. One displays white-space, the other doesn't. One allows the line to break, the other doesn't. There may be a suitable replacement character, but it seems unlikely to be nbsp. I have trouble imagining that this would block release though. On the other hand, I have no real affiliation to the project.

in reply to:  2 comment:3 by hyuga <hyugaricdeau@…>, 16 years ago

Replying to evantdster@gmail.com:

Non-breaking spaces and zero-width spaces are basically opposite things. One displays white-space, the other doesn't. One allows the line to break, the other doesn't. There may be a suitable replacement character, but it seems unlikely to be nbsp. I have trouble imagining that this would block release though. On the other hand, I have no real affiliation to the project.

True, but whether it breaks or not doesn't seem to particularly matter here. The only goal here is to get IE to behave, which this fix seems to achieve. I haven't managed to get any other space character to be displayed properly by IE without a fair amount of tweaking that users can't be expected to have to do if they don't want all those little squares in their repository browser (and believe me, I wish it weren't the case, but they will complain about it).

by Christian Boos, 16 years ago

Attachment: expander-nbsp-r6363.patch added

Alternative fix, using &nbsp; for all browsers.

comment:4 by Christian Boos, 16 years ago

Keywords: expander added
Status: newassigned

I also think that in this case, using a &nbsp; could be made to work.

Can you confirm that this works for IE6 (can't test that anymore myself)?

Seems to work fine with IE7, Opera and FF, but I'd like to get some more feedback before committing the fix.

comment:5 by hyuga <hyugaricdeau@…>, 16 years ago

I tested it in Opera 9, IE6, and FF2 with no problem. The padding/margin adjustments seem to make up for the extra space well enough.

comment:6 by Christian Boos, 16 years ago

Resolution: fixed
Status: assignedclosed

Patch applied in [6375], thanks for the feedback!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.