Disable Submit Ticket Button

[anonymous]

It would be a nice idea to disable the Submit ticket button until the Preview button has been clicked. This is similar to editing wikipedia pages and may prevent to many errors in tickets.

[Christian Boos]

Interesting idea, I wondered what to do about that myself at times.

The pros:

• as you said, fewer silly mistakes, but see cons. 1
• you anyway always do a preview, so this just saves you one choice and makes it easier

The cons:

• well, the most silly errors won't be trapped by a forced preview: not looking for duplicate tickets, not RTFM'ing, creating tickets for support questions that should rather be asked on the mailing list, etc.
• the actual "errors" on ticket creation can be trapped on Submit as well, by the way of warnings (like when you forget to provide the summary, or any other mistake spotted by a ITicketManipulator plugin)
• this enforces some process, with one additional forced step

Opinions?

[Christian Boos]

Ah yes, forgot to mention that the patch is trivial, in case you want to do it for your Trac:

trac/ticket/templates/ticket.html

@@ -379 +379 @@
             <input type="hidden" name="cnum" value="${cnum}" />
           </py:if>
           <input type="submit" name="preview" value="Preview" accesskey="r" />&nbsp;
-          <input type="submit" value="${ticket.exists and 'Submit changes' or 'Create ticket'}" />
+          <input py:if="preview_mode" type="submit" value="${ticket.exists and 'Submit changes' or 'Create ticket'}" />
 
         </div>
 

[Emmanuel Blot]

Replying to cboos:

Opinions?

Maybe through a site-wide configuration option, although as cmlenz and other people have noticed, there are already a bazillion of config options. I've had already implemented something similar for the wiki page edition, to force people to add a comment to their changes, and limit the "save to preview" syndrome.

It can really be useful, so I'm +1 - but fear the config option monster…

[Christian Boos]

Well, I think this ticket is more about deciding if it's worth changing the current behavior rather than to introduce a config option (not that I'm generally against choice, but in this case I think a config option is overkill).

[Emmanuel Blot]

Replying to cboos:

Well, I think this ticket is more about deciding if it's worth changing the current behavior rather than to introduce a config option (not that I'm generally against choice, but in this case I think a config option is overkill).

At least, it should be consistent with other preview/save edition modes in other Trac pages, such as the wiki.

[m.galante@…]

This could also prevent some of the problems described in #454.

[guto.carlos@…]

Hi,

i wan´t to add another submit button in template for Create and Accept button - when creating a new ticket

Can anyone help me?

[thomas.akesson@…]

There is a related issue with the "automatic preview" when writing comments. On slow connections/servers the preview might take a few seconds. Sometimes, when clicking "Submit changes" while the "automatic preview" is being fetched, the click on "Submit changes" is lost (and you find yourself wondering why nothing is happening a while later).

Are other users experiencing this? It could be just specific browsers (I regularly use Opera and FF).

[Ryan J Ollos]

This can easily be implemented using JavaScript added through site.html (see TracInterfaceCustomization#SiteAppearance). I suspect we would have too many complaints if we changed the behavior now to force a preview. See also ​th:ForceCommentPlugin.