Opened 17 years ago
Closed 14 years ago
#6512 closed enhancement (duplicate)
Add the user name of the author of a ticket change to the 'Sender' field
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | notification | Version: | devel |
Severity: | normal | Keywords: | patch |
Cc: | Thijs Triemstra | Branch: | |
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
We are trying to improve the usefulness of Trac's notification e-mails, by adding the user name to the 'Sender' field. This makes it easier to trac who made the changes in your e-mail app.
The patch works as follows: it adds a paramater to NotifyEmail's send method. The caller (in this case TicketNotify) can specify an author. Ticket notify looks up the author of a change, or the reporter in case of a new bug, and passes this on. The smtp_from_name parameter acts as an override, if it is set, the author parameter is ignored.
I doubt this patch conforms to your coding standards: it is meant as a quick hack to our local installation, nevertheless, it might be a solution for other users.
Attachments (1)
Change History (8)
by , 17 years ago
Attachment: | improved_notifications_6333.diff added |
---|
comment:1 by , 17 years ago
Hi - i'm really interested in getting this patch to work, but i can't seem to merge this into my notifications.py's, are you on 0.11 version??
comment:2 by , 17 years ago
Yes, it was made against revision 6361 (beta 1). I'm pretty sure it should apply cleanly. Perhaps you can apply it manually.
comment:4 by , 16 years ago
Keywords: | patch added |
---|---|
Milestone: | → 2.0 |
Owner: | removed |
comment:6 by , 14 years ago
Cc: | added |
---|
comment:7 by , 14 years ago
Milestone: | unscheduled |
---|---|
Resolution: | → duplicate |
Status: | new → closed |
#8360 has a patch implementing this functionality, so I'm closing this as a duplicate.
Quick and dirty patch