Edgewall Software
Modify

Opened 12 years ago

Closed 9 years ago

Last modified 9 years ago

#6458 closed enhancement (fixed)

Timeline unnecessarily populates email_map from all known users

Reported by: jeremy@… Owned by: Remy Blank
Priority: normal Milestone: 0.12.1
Component: timeline Version: 0.10.4
Severity: normal Keywords: get_known_users
Cc: Branch:
Release Notes:
API Changes:

Description

env.get_known_users is an extremely expensive query if you have many sessions and attributes. The timeline uses it to populate a user name→email map for RSS author emails. This map is populated even if format != 'rss'.

Simply wrapping the email_map construction with an rss format check gives a large speedup for normal timeline use.

In the future, the user schema should extracted from the session or at least cached in-process.

Attachments (0)

Change History (4)

comment:1 by Christian Boos, 12 years ago

Milestone: 0.12

In 0.11, the email_map is effectively only done for RSS requests.

But you're right, even so, that's probably an important aspect to optimize when we refactor the user/group handling in 0.12.

comment:2 by jeremy@…, 12 years ago

This affects /reports in the same way (building email_map)

comment:3 by Remy Blank, 9 years ago

Milestone: next-major-0.1X0.12.1
Resolution: fixed
Status: newclosed

Fixed in [9937], together with a bug in the report RSS template that prevented the author tags from appearing at all.

comment:4 by Remy Blank, 9 years ago

Owner: changed from Christian Boos to Remy Blank

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.