Edgewall Software
Modify

Opened 12 years ago

Closed 12 years ago

Last modified 7 years ago

#6447 closed enhancement (wontfix)

show content of attached doc/xls/pdf/.. files

Reported by: anonymous Owned by: Jonas Borgström
Priority: normal Milestone:
Component: attachment Version:
Severity: normal Keywords: pdf, word, doc
Cc: Branch:
Release Notes:
API Changes:

Description

would be nice to have a macro (like the Makro), which shows the content of an attached file

Attachments (0)

Change History (24)

comment:1 by Alec Thomas, 12 years ago

Resolution: wontfix
Status: newclosed

This will not go into Trac core. You should open a Request-a-Hack ticket on TracHacks.

comment:2 by anonymous, 12 years ago

Resolution: wontfix
Status: closedreopened

this needs be put into the core if trac want to be more robust a better ticket management system

comment:3 by anonymous, 12 years ago

Component: generalattachment
Milestone: 0.10.5
Priority: normalhighest
Severity: normalmajor

honestly who doesn't attach these types of files

in reply to:  3 comment:4 by Emmanuel Blot, 12 years ago

Milestone: 0.10.5
Priority: highestnormal
Resolution: wontfix
Severity: majornormal
Status: reopenedclosed

Replying to anonymous:

honestly who doesn't attach these types of files

Sane people ?

comment:5 by henke.mike@…, 12 years ago

Keywords: pdf word doc added
Milestone: 0.10.5
Priority: normalhigh
Resolution: wontfix
Severity: normalmajor
Status: closedreopened

So trac should be not extended to and integrated with other standard systems, most sane business use like word docs and pdf files?

comment:6 by Noah Kantrowitz, 12 years ago

Resolution: wontfix
Status: reopenedclosed

Make a patch that implements this, and then we will talk. +1 on making this a plugin.

comment:7 by Noah Kantrowitz, 12 years ago

Milestone: 0.10.5not applicable
Priority: highnormal
Severity: majornormal

comment:8 by henke.mike@…, 12 years ago

Resolution: wontfix
Status: closedreopened

I don't think this is as complicated as a plugin. Trac just need to recognize MIME content type of the page by extension (.pdf, .doc, .xls) and then set the content type. The content type determines how the browser or client interprets the page contents. The following are some of the content type values you can use:

application/msword application/msexcel application/pdf

I looked at the trac.ini file under mimiviewer but it isn't clicking for me. I think the mime_map needs changed like "text/x-dylan:dylan,text/x-idl:ice,text/x-ada:ads:adb :application/pdf:pdf "

in reply to:  5 comment:9 by hyuga <hyugaricdeau@…>, 12 years ago

Resolution: wontfix
Status: reopenedclosed

Replying to henke.mike@gmail.com:

So trac should be not extended to and integrated with other standard systems, most sane business use like word docs and pdf files?

At my business (which is sane in some areas moreso than others) there are several people who use AutoCAD on a daily basis. Are you suggesting that attached AutoCAD files should be shown?

Supporting Word and PDF is one thing, but then where do you stop? Why not Excel spreadsheets? Why not Open Office documents? Presentations? Why, the Trac devs could just drop everything and spend all day writing platform independent engines to render every file format imaginable in HTML.

comment:10 by henke.mike@…, 12 years ago

Good point. Maybe trac should be more friendly to customizing different attachments types inline (in browser) instead of actually implementing the specific attachment types. I still haven't found any good examples to do this and I bet the sane Trac devs actually do with their attachments whether being autoCAD, pdfs, doc, etc, which ever they use so they don't have to download the attachments everytime.

comment:11 by hyuga <hyugaricdeau@…>, 12 years ago

Er, there already is, in the form of IHTMLPreviewRenderer. But you'd still have to write a custom implementation to display most any file format that isn't already supported. There's just no way around that. But the fact that that interface exists is why this would be a plugin candidate.

comment:12 by henke.mike@…, 12 years ago

Cool. Thanks. I will take a look @ IHTMLPreviewRenderer

comment:13 by henke.mike@…, 12 years ago

any examples of how to use iIHTMLPreviewRenderer with a supported and unsupported file formats? i searched the trac site and didn't find any except a brief mention [WikiContext]. thanks in advance

comment:14 by anonymous, 12 years ago

Resolution: wontfix
Status: closedreopened

comment:15 by Emmanuel Blot, 12 years ago

Resolution: wontfix
Status: reopenedclosed

comment:16 by anonymous, 12 years ago

great everyone is so helpful in answering questions, nice to know this community is so open and friendly

comment:17 by henke.mike@…, 12 years ago

Resolution: wontfix
Status: closedreopened

I did get a suggestion. "dont use the direct way via trac my.doc but via web-server [http:/.../svn/my.doc]." couldn't this link be easily added to the attachment section of the ticket along with on the trac attachment linked page?

Or couldn't somehow the attachment/ticket use wiki format like to embed attachments similiar to images No image "sane.jpg" attached to Ticket #6447 but like Object(sane.pdf) or Object(sane.doc)

comment:18 by anonymous, 12 years ago

duplicate Ticket #2883

comment:19 by anonymous, 12 years ago

related Ticket #5718

comment:20 by anonymous, 12 years ago

related Ticket but closed as duplicate #6132

comment:21 by hyuga <hyugaricdeau@…>, 12 years ago

Resolution: wontfix
Status: reopenedclosed

If you want to include examples, prefix them with ! to disable the macro processing. For example, ![[Image(sane.jpg)]] produces [[Image(sane.jpg)]]

At any rate, if you want a macro to embed object tags, that's different, and I'm sure such a thing is already out there. But such a thing also has security risks, which is why it's probably not included in the core. Now please stop reopening this ticket.

comment:22 by Christian Boos, 7 years ago

Milestone: not applicable

(clearing report:35)

comment:23 by anonymous, 7 years ago

Surely this doesn't really need too much product-specific effort, it can remain pretty generic.

As long as what Trac spits out is something like:

<object type="application/pdf" data="./path/to/attachment"><a href="./path/to/attachment">Attachment Name</a></object>

Then I don't see why there's such an aversion to this suggestion.

comment:24 by anonymous, 7 years ago

<object type="application/pdf" data="./path/to/attachment">
    <a href="./path/to/attachment">Attachment Name</a>
</object>

If the Trac admin thinks it's a security risk, then he/she can turn it off.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.