Opened 17 years ago
Closed 17 years ago
#6438 closed enhancement (fixed)
max attachment filesize info in upload form
Reported by: | anonymous | Owned by: | osimons |
---|---|---|---|
Priority: | normal | Milestone: | 0.11 |
Component: | attachment | Version: | devel |
Severity: | minor | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
would be nice to see a hint in the attachment upload form, where you can see the max filesize for attachments.. this info is also usefull for the users
Attachments (3)
Change History (7)
by , 17 years ago
Attachment: | t6438-r6280-attachment_max_size.diff added |
---|
follow-up: 2 comment:1 by , 17 years ago
Component: | general → attachment |
---|---|
Milestone: | → 0.11.1 |
Owner: | changed from | to
Severity: | normal → minor |
Version: | → devel |
Good idea. Attached a patch that instead of 'File:' renders 'File (max. 256 kb):' (or whatever the current max is).
Feedback? Commit?
by , 17 years ago
Attachment: | t6438-r6280-attachment_max_size-b.diff added |
---|
Forgot that it can be set to '0' (zero) for unlimited. No point in displaying it then.
comment:2 by , 17 years ago
Replying to osimons:
Good idea. Attached a patch that instead of 'File:' renders 'File (max. 256 kb):' (or whatever the current max is).
Feedback? Commit?
+1, although the pretty_size() function could be revisited a little bit to remove useless data - maybe at a later time.
Example:
File (256.0 kB):
256 kB
would look more natural.
by , 17 years ago
Attachment: | t6438-r6280-attachment_max_size-c.diff added |
---|
Another version, with the message in the template
comment:3 by , 17 years ago
I attached an updated version of the patch, with the pretty_size()
variation and also putting the message directly in the template, which I think should be preferred whenever possible.
Ok for 0.11.
comment:4 by , 17 years ago
Milestone: | 0.11.1 → 0.11 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Last patch from cboos committed as [6286]. Only changed the text a little to make it less obtrusive - now just says 'size limit'.
Patch with information on max size for uploads.