Edgewall Software
Modify

Opened 17 years ago

Closed 14 years ago

Last modified 14 years ago

#6433 closed defect (fixed)

SpamFilter has no input validation on Configuration screen in webadmin

Reported by: datakid@… Owned by:
Priority: low Milestone: plugin - spam-filter
Component: plugin/spamfilter Version: 0.10.4
Severity: major Keywords: spamfilter karma validation
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christian Boos)

One of my trac admins changed the Minimum Karma level to "0.5" (ie a half) and now we cannot get back to the configuration screen at http://trac.site.com/admin/spamfilter/config .

The error thrown is:

Internal Error

expected integer, got u'0.5'

On trac v 0.10.4 and TracSpamFilter 0.2.1dev-r5943

Attachments (0)

Change History (6)

comment:1 by Christian Boos, 17 years ago

Milestone: not applicable
Priority: normallow

comment:2 by anonymous, 16 years ago

With the ini-admin plugin, you cound go to the URL "/admin/tracini/spam-filter" and change the "min_karma" setting there (or search for it in your trac.ini and edit it there).

Nevertheless, if an integer is expected, the plugin should not let anything but an integer through - i.e. that wrong value should not have been saved.

comment:3 by Christian Boos, 15 years ago

Description: modified (diff)
Milestone: not applicablespam-filter-plugin
Owner: Matthew Good removed

comment:4 by Dirk Stöcker, 14 years ago

Resolution: fixed
Status: newclosed

comment:5 by Remy Blank, 14 years ago

Could you please add a link to the changeset that fixed this issue?

comment:6 by Dirk Stöcker, 14 years ago

I don't know. Was long before my time. I tested it and it works correctly and the code says the same.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.