Preview feature is broken: inlined images are missing

[Emmanuel Blot]

Using Trac 0.11dev-r6230

When a wiki page contains some [[Image()]] macros, the image links are invalid.
The resulting preview shows only the wiki text, with image placeholders - that actually depend on how the browser renders the missing image links.

It seems the error is due to the version management of the page:

• In plain mode, image links are unversionned, such as in

  <img src="/project/raw-attachment/wiki/PageName/image.png" />
  

• In preview/edit mode, image links are "versionned": the wiki page name part of the link contains the version of the page, such as in

  <img src="/project/raw-attachment/wiki/PageName%3Fversion%3D4/image.png" />
  

[osimons]

When building attachment support for my blog plugin, I noticed the same behavior. Understanding that the attachment module doesn't support versioned resources, I basically sent in resources with id=None.

Now, seeing this issue, it makes me think this is better resolved in the Attachment module - by having that strip off the version element when dealing with resources, particularly when constructing URLs as it uses the resource path as basis for path on disk.

There will be a lot of these resource descriptors flying around, so Attachment should handle them appropriately by never including ...?version=nn in filename. I certainly don't foresee us saving Attachments by both page and version, so ignoring version would be the easy alternative.

I can look into this if you like, as I think I pretty much know where and how. If so, just reassign it to me and I'll pick it up.

[Christian Boos]

Maybe. But I think it's perhaps better in this case to fix the wiki preview as well, e.g.

trac/wiki/web_ui.py

@@ -132 +132 @@
                 if action == 'edit' and not has_collision:
                     self._do_save(req, versioned_page)
                 else:
-                    return self._render_editor(req, versioned_page, action,
-                                               has_collision)
+                    return self._render_editor(req, page, action, has_collision)
             elif action == 'delete':
                 self._do_delete(req, versioned_page)
             elif action == 'diff':

[Emmanuel Blot]

Replying to cboos:

Maybe. But I think it's perhaps better in this case to fix the wiki preview as well, e.g.

Agreed. As long as Trac is not able to manage versions of attached files, I don't see any reason to provide the versioned_page info.

osimons, I'm not sure if you were asking me or cboos to reassign the ticket. Feel free to get the ownership.

[osimons]

Nothing wrong with the preview - except that is works with faulty data. This solves it as far as i can see.:

trac/attachment.py

@@ -483 +483 @@
         if format == 'raw':
             kwargs.pop('format')
             prefix = 'raw-attachment'
-        parent_href = get_resource_url(self.env, resource.parent, Href(''))
+        parent_href = get_resource_url(self.env, resource.parent(version=None),
+                                        Href(''))
         if not resource.id:
             return href(prefix, parent_href) + '/'
         else:

[osimons]

If solving this through attachment, #6375 is kind of related - showing problem with spaces and quoting (in addition to appending version as well).

[Christian Boos]

Committed change in comment:3 in r6239. Simon, feel free to finish this ticket with the comment:5 change.

[osimons]

Committed comment:5 patch in [6241] (+ issue from #6375).

[Emmanuel Blot]

Thanks, works smoothly.