[PATCH] Etag responses need Vary header
|Reported by:||Owned by:|
|Severity:||normal||Keywords:||etag review patch|
The Request.check_modified() function which adds the Etag and checks If-None-Match should be adding a "Vary *" header along with the initial response and the 304 response.
This creates a problem of the browser always caching attachments when mod_deflate is used. mod_deflate adds a "Vary Accept-Encoding" header which makes the browser believe that only Accept-Encoding is used to determine cacheability. "Vary *" is needed to let the browser know that other information is used to make caching decisions.
Also note that Request.send_file() function does not send a Cache-Control header. That should be OK if Vary * is sent.
Change History (13)
comment:5 by , 10 years ago
|Component:||general → web frontend|
|Milestone:||unscheduled → 0.13|