Modify ↓
Opened 17 years ago
Closed 15 years ago
#6337 closed defect (wontfix)
Timeline "days back" value is not propagated to build the RSS format link.
| Reported by: | Emmanuel Blot | Owned by: | Remy Blank |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | timeline | Version: | devel |
| Severity: | minor | Keywords: | rss bitesized |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
Whatever the current "days back" value set in the Timeline view, the RSS feed seems hardwired to "90 days".
Tested w/ r6149
Attachments (1)
Change History (7)
comment:1 by , 17 years ago
| Milestone: | → 0.11.1 |
|---|
comment:3 by , 15 years ago
| Keywords: | bitesized added |
|---|
by , 15 years ago
| Attachment: | patch_6337.patch added |
|---|
Put the user-chosen daysback argument in the RSS URL.
follow-up: 6 comment:4 by , 15 years ago
I am not sure why in first place trac used hardcoded daysback=90 value:
- I've attached a patch to put the real user-chosen value. I've tested that on Firefox (as an RSS client) and on KDE RSS client (Akregator) - it seems to behave well.
- I don't really understand the rationale behind it: it's a *FEED*, this daysback argument will not change anything except for the initial feed-addition. Moreover, a user putting a too *SMALL* value might cause harm and confusion, because he may lose track on recent changes if he haven't been connected for a day, for example.
I'd recommend closing this ticket and leaving the daysback value as is, not applying my patch.
comment:5 by , 15 years ago
| Milestone: | next-minor-0.12.x → 0.12 |
|---|---|
| Owner: | changed from to |
comment:6 by , 15 years ago
| Milestone: | 0.12 |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
Replying to Oren Held <oren@…>:
I'd recommend closing this ticket and leaving the daysback value as is, not applying my patch.
Your analysis makes sense. Let's keep the 90 days.
Note:
See TracTickets
for help on using tickets.
The hard-wiring to 90 days seems to have been done on purpose. Hopefully jonas can comment on the rationale. I don't think it's a problem to change the RSS link to match exactly the currently selected prefs (except for the start date, of course).