Error is not reported for invalid SQL in report queries.

[tjorvi@…]

Instead of reporting an error, trac act as if the report executed correctly but returned no results.

This seems to be because of a parameter mismatch between the exception handler in ReportModule._render_view(), and the report_view.html template.

report_view.html is expecting report.message to contain error messages, but _render_view is sending message.

Here is a patch that solves the problem in one fashion:

Index: trac/ticket/report.py
===================================================================
--- trac/ticket/report.py       (revision 6114)
+++ trac/ticket/report.py       (working copy)
@@ -279,8 +279,8 @@
         try:
             cols, results = self.execute_report(req, db, id, sql, args)
         except Exception, e:
-            data['message'] = _('Report execution failed: %(error)s',
-                                error=to_unicode(e))
+            data['report'] = {'message':_('Report execution failed: %(error)s',
+                                error=to_unicode(e))}
             return 'report_view.html', data, None

         sort_col = req.args.get('sort', '')

[Christian Boos]

You're right. Thanks for the report & patch!

[Christian Boos]

(well, incidentally I already fixed it in the context-refactoring branch, waiting for the merge)

[Christian Boos]

Now in trunk (r6139).