Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#6268 closed defect (wontfix)

Wiki page edit buttons don't work with IE

Reported by: trac-ja@… Owned by: Christian Boos
Priority: high Milestone:
Component: wiki system Version: devel
Severity: major Keywords: iexplorer
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christian Boos)

Wiki page edit buttons (Preview, Merge and Save) don't work with IE7 (maybe, IE6 too).

These <input> elements don't have id attribute.

Update

It appears the id attribute has probably nothing to do with the problem (comment:4). Rather, IE seems unable to edit big wiki pages (comment:5).

Attachments (0)

Change History (10)

comment:1 by trac-ja@…, 16 years ago

Ummm, I encountered stack tracks and I cannot attach file….

  • trac/wiki/templates/wiki_edit.html

     
    122122        </fieldset>
    123123        <div class="buttons" py:choose="action">
    124124          <py:when test="'collision'">
    125             <input type="submit" name="preview" value="Preview" disabled="disabled" />&nbsp;
    126             <input type="submit" name="merge" value="Merge changes" accesskey="r" />&nbsp;
    127             <input type="submit" name="save" value="Submit changes" disabled="disabled" />&nbsp;
     125            <input type="submit" id="preview" name="preview" value="Preview" disabled="disabled" />&nbsp;
     126            <input type="submit" id="merge" name="merge" value="Merge changes" accesskey="r" />&nbsp;
     127            <input type="submit" id=="save" name="save" value="Submit changes" disabled="disabled" />&nbsp;
    128128          </py:when>
    129129          <py:otherwise>
    130             <input type="submit" name="preview" value="Preview Page" accesskey="r" />&nbsp;
    131             <input type="submit" name="diff" value="Review Changes" accesskey="r" />&nbsp;
     130            <input type="submit" id="preview" name="preview" value="Preview Page" accesskey="r" />&nbsp;
     131            <input type="submit" id="diff" name="diff" value="Review Changes" accesskey="r" />&nbsp;
    132132            <input type="submit" id="save" name="save" value="Submit changes" />&nbsp;
    133133          </py:otherwise>
    134134          <input type="submit" name="cancel" value="Cancel" />

comment:2 by trac-ja@…, 16 years ago

I forget, comment:1 is a patch for source:trunk@6114 .

comment:3 by Christian Boos, 16 years ago

Keywords: needinfo added
Milestone: 0.11

Sorry, I can't reproduce the problem with IE7. Are you sure that your problem is related to the absence of "id" attributes? Btw, the "preview" id is already taken by the preview fieldset.

comment:4 by trac-ja@…, 16 years ago

Severity: criticalnormal

You are right, this is not relate id attribute.

But there is another that sometime wiki pages are not dipalayed. Instead, IE7 displays "DNS Error" (as res://ieframe.dll/dnserrordiagoff.htm).

Sequence:

  1. Access a Wiki page. (and login you need)
  2. Push "Edit this page" button.
  3. Push one of "Preview Page", "Review Changes" or "Cancel" buttons quickly or repeatedly.

I found this problem when Trac runs as tracd. And I didn't encount Trac runs with cgi, fcgi, mod_python.

I think this problem causes IE7 or tracd's connection or session handling, however I don't have any reasons.

comment:5 by Christian Boos, 16 years ago

Keywords: iexplorer added; needinfo removed
Milestone: 0.11.1
Severity: normalmajor

Does that happen for big pages? For me, the limit is approximately 11933 bytes. That problem is known but not really understood. I think there's no ticket dedicated to that problem, so this one seems to be the place for tracking that problem.

comment:6 by Jeroen Ruigrok van der Werven, 16 years ago

Has any of you used ethereal or tcpdump to capture the session to see on a network level which side is the problem maker?

comment:7 by Christian Boos, 16 years ago

Priority: normalhigh

comment:8 by Christian Boos, 16 years ago

Description: modified (diff)

#2929 was similar, at least the symptoms described in that ticket are the same that what happens when trying to edit long wiki pages.

comment:9 by john.m.camara, 16 years ago

Resolution: wontfix
Status: newclosed

Works for me on ie7 and r6700

comment:10 by Christian Boos, 16 years ago

Milestone: 0.11.1

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.