Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

#6253 closed defect (fixed)

wiki\formatter.py assumes the length of os.linesep is 1.

Reported by: roncli <roncli@…> Owned by: Christian Boos
Priority: normal Milestone: 0.11
Component: wiki system Version: 0.10.4
Severity: trivial Keywords: OneLinerFormatter
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In the format function of the OneLinerFormatter class, line 911 attempts to strip a line separator from the end of the line. It assumes that the length of the line separator is 1, but this is not true on Windows, where it is 2.

        result = buf.getvalue()[:-1]

Attachments (0)

Change History (2)

comment:1 by Christian Boos, 17 years ago

Milestone: 0.11
Severity: normaltrivial

I don't think this will change anything, but you're right, it should behave consistently with the actual len of os.linesep.

comment:2 by Christian Boos, 17 years ago

Resolution: fixed
Status: newclosed

Fixed in r6112. I think there's no point to backport this to 0.10-stable.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.