"wiki_to_html" fails when called without a "req" object

[ilias@…]

Based on the documentation within "context.py" this code should work:

  from trac.wiki.formatter import wiki_to_html
  htmltxt = wiki_to_html('WikiStarter',self.env, None)

It should just format "WikiStarter" to real html link.

The code fails (0.11dev-r5897) with the error:

AttributeError: 'NoneType' object has no attribute 'perm'

The location is here:

File "f:\pj\infra\infra\trac\trac\wiki\api.py", line 345, in _format_link

line 345 of the code:

        if 'WIKI_VIEW' not in req.perm(context):

There should be a check if "req" is available, thus "wiki_to_html" works independent of the existence of the req object.

[ilias@…]

Maybe there should be a test-case, too, which checks if "wiki_to_html" works with a "None" req object.

[ilias@…]

Simple patch, please verify

[Noah Kantrowitz]

This will not happen as a req is needed for security enforcement and URL establishment.

[Christian Boos]

Replying to nkantrowitz:

This will not happen as a req is needed for security enforcement and URL establishment.

Well, that's true for now, but this is something we'll try to address in future releases, as neither the security enforcement and the URL generation should be dependent on the trac.web layer. In the longer term, off-line wiki processing should be possible.

So, for the time being, "wiki_to_html" will fail when called without a "req" object.

[osimons <simon-code@…>]

Replying to cboos:

So, for the time being, "wiki_to_html" will fail when called without a "req" object.

Actually, not quite true. It will only fail if it encounters items that it needs to check for permissions - like links, which is usually pretty much everything :-)

This works:

htmltxt = wiki_to_html("= A heading =\nAnd some ''markup''.", self.env, None)

[Noah Kantrowitz]

Replying to osimons <simon-code@bvnetwork.no>:

Replying to cboos:

So, for the time being, "wiki_to_html" will fail when called without a "req" object.

Actually, not quite true. It will only fail if it encounters items that it needs to check for permissions - like links, which is usually pretty much everything :-)

Not to mention that being req-less would make macro expansion tricky.

[ilias@…]

Replying to cboos:

Replying to nkantrowitz:

This will not happen as a req is needed for security enforcement and URL establishment.

Well, that's true for now, but this is something we'll try to address in future releases, as neither the security enforcement and the URL generation should be dependent on the trac.web layer. In the longer term, off-line wiki processing should be possible.

So, for the time being, "wiki_to_html" will fail when called without a "req" object.

Can you estimate a Milestone for this?

[Christian Boos]

That ticket was about a specific problem:

Based on the documentation within "context.py" this code should work:

  from trac.wiki.formatter import wiki_to_html
  htmltxt = wiki_to_html('WikiStarter',self.env, None)

but:

• context.py will be gone before 0.11 gets released
• for the more general problem of separating the web layer and the rendering layer, this is an open question which has not yet a corresponding milestone

So this ticket is a wontfix because the specific problem it raised won't be fixed (you can consider it was a documentation issue within context.py if you want).

(Ilias, you might want to experiment with the new extension we put in place on t.e.o: tickets will delete themselves if they changes too many times from wontfix to reopen … ;-) ).

[ilias@…]

Replying to cboos: […]

• for the more general problem of separating the web layer and the rendering layer, this is an open question which has not yet a corresponding milestone

[…]

I assumed that this separation is already existent (docu in context.py seemed to confirm this). Thus i assumed a regression here.

It is now clear that the subsystem "rendering" is directly coupled to "web" (which means that a wiki page cannot be transformed to html without the existence of a web request).

Thanks for the info.

[Christian Boos]

Thanks for not having reopened the ticket ;-)