Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

#6142 closed enhancement (worksforme)

The "req" should be available within "wiki_page_changed"

Reported by: ilias@… Owned by: Christian Boos
Priority: normal Milestone:
Component: wiki system Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I'm not sure if this is a defect or and enhancement.

The method signature:

def wiki_page_changed(self, page, version, t, comment, author,

ipnr):

The request which has changed the wiki-page is not available. But in some cases, the information is needed to decide for the validity of the change.

Attachments (0)

Change History (2)

comment:1 by osimons <simon-code@…>, 17 years ago

I assume you refer to the definiton of trac.wiki.api.IWikiChangeListener.wiki_page_changed()? The methods of Listener interfaces in general are not intended for validation as they are after-the-fact events - called when a successful submission has already been made in the database. The same behavior is for instance mirrored in the trac.ticket.api.ITicketChangeListener interface.

If you need validation, you should implement the trac.wiki.api.IWikiPageManipulator interface.

Please close the ticket as worksforme if you agree with this.

in reply to:  1 comment:2 by ilias@…, 17 years ago

Resolution: worksforme
Status: newclosed

Replying to osimons <simon-code@bvnetwork.no>: […]

Please close the ticket as worksforme if you agree with this.

Thank you for the thorough elaborations.

My missunderstanding.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.