wrap email addresses

[r.sokoll@…]

I'm on r6029

trac.ini has

[trac]
show_email_addresses = true

All addresses in CC field are in one long line. If show_email_addresses is set to false, the addresses are wrapped.

[Christian Boos]

Can you please try the following patch?

Index: trac/ticket/web_ui.py
===================================================================
--- trac/ticket/web_ui.py	(revision 6038)
+++ trac/ticket/web_ui.py	(working copy)
@@ -942,12 +942,11 @@
                                     .render_milestone_link(href, milestone,
                                                            milestone)
             elif name == 'cc':
-                self.env.log.debug('Checking MUPPETS %s', context)
+                all_cc = cc_list(ticket[name])
                 if not (Chrome(self.env).show_email_addresses or \
                         'EMAIL_VIEW' in req.perm(context)):
-                    field['rendered'] = ', '.join(
-                        [obfuscate_email_address(cc)
-                         for cc in cc_list(ticket[name])])
+                    all_cc = [obfuscate_email_address(cc) for cc in all_cc]
+                field['rendered'] = ', '.join(all_cc)
                     
             # ensure sane defaults
             field.setdefault('optional', False)

I had some difficulties into reproducing the issue, until I realized that we now normalize the list before writing the field in the db. So this problem happens only with old existing CC lists containing no spaces and the fix is only necessary for those.

[r.sokoll@…]

Perfect! Thanks a lot!

[Christian Boos]

Fix applied in r6073.