expanding browser source tree, empty root folder

[domluc]

When I navigate to Browse Source, and expand and collapse tree of repository the root folder is cleared.

[domluc@…]

Shot before click on something

[domluc@…]

Shot after expand and collapse trees some times

[Eli Carter]

What browser are you using?

[domluc@…]

I'm using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6

[Tim Hatch]

I'm able to reproduce with Firefox 2.0.0.6/Linux also (on latest trunk, which means post. Rather strange behavior. Here's what it does:

• Expand & collapse on a single item work fine all day long.
• The first expand & collapse of any folder also work okay the first time
• Expanding the item a second time after any other item has been expanded, the text disappears permamently

Are you running post-r5890? There was one regression related to expanding dirs already noticed in that rev.

[domluc@…]

I'm running trunk (r5892), this behavior is really strange.

[Tim Hatch]

I reverted r5890 locally and that's not the issue. I'll look into it further.

[Christian Boos]

Not sure why it used to work (probably a bug now fixed in jQuery 1.1.3.1), but I think I've found a fix:

expand_dir.js

@@ -55 +55 @@
     // Note that the above will show all the already fetched subtree,
     // so we have to fold again the folders which were already collapsed.
     tr.siblings("tr.collapsed").each(function() {
-      expander.siblings("tr."+expander.get(0).id).hide();
+      tr.siblings("tr."+this.id).not(this).hide();
     });
   } else {                                // then *fetch*
     var td = expander.parents("td");

[domluc@…]

Replying to cboos:

Not sure why it used to work (probably a bug now fixed in jQuery 1.1.3.1), but I think I've found a fix:

expand_dir.js

@@ -55 +55 @@
     // Note that the above will show all the already fetched subtree,
     // so we have to fold again the folders which were already collapsed.
     tr.siblings("tr.collapsed").each(function() {
-      expander.siblings("tr."+expander.get(0).id).hide();
+      tr.siblings("tr."+this.id).not(this).hide();
     });
   } else {                                // then *fetch*
     var td = expander.parents("td");

Whhuaaa! Looks like it's correct. I modify manually it and works fine to me!

[Christian Boos]

Fix applied in r5907, as it worked fine using Firefox, IE7 and Opera.