Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

#5590 closed defect (fixed)

SecurityBranch killed ClearSilver compatibility

Reported by: Dave Abrahams <dave@…> Owned by: aat
Priority: normal Milestone: 0.11
Component: general Version: devel
Severity: critical Keywords: SecurityBranch, ClearSilver
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

This patch posted by aat on #trac fixed the problem. Here it is again for reference:

  • trac/perm.py

     
    460460
    461461    def permissions(self):
    462462        """Deprecated (but still used by the HDF compatibility layer)"""
    463         if not self._cached_all:
    464             self.env.log.warning('perm.permissions() is deprecated and '
    465                                  'is only present for HDF compatibility')
    466             perm = PermissionSystem(self.env)
    467             actions = perm.get_user_permissions(self.username)
    468             # Perform a full permission check in this context
    469             [action in self for action in actions]
    470             self._cached_all = True
    471         return [action for action, decision in
    472                 self._cache.get(None, {}).iteritems() if decision]
     463        perm = PermissionSystem(self.env)
     464        actions = perm.get_user_permissions(self.username)
     465        return [action for action in actions if action in self]

Attachments (0)

Change History (1)

comment:1 by Dave Abrahams <dave@…>, 15 years ago

Resolution: fixed
Status: newclosed

Duh, it's already fixed in trunk.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain aat.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from aat to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.