Edgewall Software

Opened 15 years ago

Last modified 3 years ago

#5506 new defect

Confusing formatting for attachments in Timeline

Reported by: anonymous Owned by:
Priority: normal Milestone: next-major-releases
Component: timeline Version: devel
Severity: minor Keywords: attachment
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:


Click on 'Ticket #1234' at the attachment line on Timeline page opens attachment page and not actual ticket as expected.

Simple solution can be done with JavaScript (attached).

Attachments (3)

timeline_links_in_attachments.diff (944 bytes ) - added by anonymous 15 years ago.
t5506.patch (1.3 KB ) - added by Ryan J Ollos 3 years ago.
Screen Shot 2019-02-13 at 13.49.17.jpg (46.1 KB ) - added by Ryan J Ollos 3 years ago.

Download all attachments as: .zip

Change History (11)

by anonymous, 15 years ago

comment:1 by Christian Boos, 15 years ago

Keywords: attachment needinfo added
Milestone: 0.11
Severity: normalminor

Well, I'm not sure this is pertinent, as the whole line gets highlighted when you hover the mouse on it, and it's clear that the entry is about an attachment. Going elsewhere (the ticket) when you click on the attachment entry might be seen confusing as well by other users.

Plus I don't think we should generate Javascript trickery from the controller. The HTML should be kept as clean as possible. A somewhat cleaner solution would be to add these callbacks using jQuery once the page is loaded. But the first point would still stand.

Other opinions?

comment:2 by anonymous, 15 years ago

Alternative is to change formatting and keep 'Ticket #1234' as plain text (now it looks like a link)

in reply to:  2 comment:3 by Emmanuel Blot, 15 years ago

Replying to anonymous:

Alternative is to change formatting and keep 'Ticket #1234' as plain text (now it looks like a link)

I'd go for this one: as the whole line is a link, the ticket number (or the name of the page for wiki attachments…) should not appear as a link. However, they (ticket number, wiki page name) should nevertheless be highlighted, which another style than wiki links.

I really don't think it is worth going down the Javascript or jQuery road here.

comment:4 by Christian Boos, 15 years ago

Keywords: needinfo removed
Milestone: 0.11

Maybe this could be reworked together with #3132, so that we could allow for multiple links in a timeline entry's title (same as CvsTrac's timeline).

comment:5 by Christian Boos, 13 years ago

Milestone: 0.11-retriage0.13

comment:6 by Ryan J Ollos, 7 years ago

Owner: Christian Boos removed

comment:7 by Dirk Stöcker, 3 years ago

Same issue reported in JOSM-Trac: https://josm.openstreetmap.de/ticket/17292

by Ryan J Ollos, 3 years ago

Attachment: t5506.patch added

comment:8 by Ryan J Ollos, 3 years ago

I'd be okay with just removing border-bottom and changing the color to something other than the red used by TracLinks: t5506.patch.

Last edited 3 years ago by Ryan J Ollos (previous) (diff)

by Ryan J Ollos, 3 years ago

Modify Ticket

Change Properties
Set your email in Preferences
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.