Confusing formatting for attachments in Timeline

[anonymous]

Click on 'Ticket #1234' at the attachment line on Timeline page opens attachment page and not actual ticket as expected.

Simple solution can be done with JavaScript (attached).

[Christian Boos]

Well, I'm not sure this is pertinent, as the whole line gets highlighted when you hover the mouse on it, and it's clear that the entry is about an attachment. Going elsewhere (the ticket) when you click on the attachment entry might be seen confusing as well by other users.

Plus I don't think we should generate Javascript trickery from the controller. The HTML should be kept as clean as possible. A somewhat cleaner solution would be to add these callbacks using jQuery once the page is loaded. But the first point would still stand.

Other opinions?

[anonymous]

Alternative is to change formatting and keep 'Ticket #1234' as plain text (now it looks like a link)

[Emmanuel Blot]

Replying to anonymous:

Alternative is to change formatting and keep 'Ticket #1234' as plain text (now it looks like a link)

I'd go for this one: as the whole line is a link, the ticket number (or the name of the page for wiki attachments…) should not appear as a link. However, they (ticket number, wiki page name) should nevertheless be highlighted, which another style than wiki links.

I really don't think it is worth going down the Javascript or jQuery road here.

[Christian Boos]

Maybe this could be reworked together with #3132, so that we could allow for multiple links in a timeline entry's title (same as CvsTrac's timeline).

[Dirk Stöcker]

Same issue reported in JOSM-Trac: ​https://josm.openstreetmap.de/ticket/17292

[Ryan J Ollos]

I'd be okay with just removing border-bottom and changing the color to something other than the red used by TracLinks: t5506.patch​.