Email notifications are broken by [747]

[mrowe@…]

Some of the changes made in [747] break email notifications. Attempting to create or update a ticket results in a traceback similar to the following:

Traceback (most recent call last):
  File "/usr/lib/python2.3/site-packages/trac/core.py", line 492, in cgi_start
    real_cgi_start()
  File "/usr/lib/python2.3/site-packages/trac/core.py", line 487, in real_cgi_start
    dispatch_request(path_info, args, req, env, database)
  File "/usr/lib/python2.3/site-packages/trac/core.py", line 397, in dispatch_request
    module.run()
  File "/usr/lib/python2.3/site-packages/trac/Module.py", line 45, in run
    self.render()
  File "/usr/lib/python2.3/site-packages/trac/Ticket.py", line 387, in render
    self.save_changes (id)
  File "/usr/lib/python2.3/site-packages/trac/Ticket.py", line 322, in save_changes
    tn.notify(ticket, newticket=0, modtime=time.time())
  File "/usr/lib/python2.3/site-packages/trac/Notify.py", line 223, in notify
    NotifyEmail.notify(self, ticket['id'], subject)
  File "/usr/lib/python2.3/site-packages/trac/Notify.py", line 127, in notify
    Notify.notify(self, resid)
  File "/usr/lib/python2.3/site-packages/trac/Notify.py", line 74, in notify
    rcpts = self.get_recipients(resid)
  File "/usr/lib/python2.3/site-packages/trac/Notify.py", line 270, in get_recipients
    cursor.execute('SELECT reporter,cc FROM ticket WHERE id=%s', ticket['id'])
TypeError: string indices must be integers

This appears to be due to using ticket['id'] instead of either self.ticket['id'] or just plain ticket.

[Jonas Borgström]

Should be fixed in [761].