Modify ↓
Opened 18 years ago
Closed 18 years ago
#5413 closed enhancement (fixed)
RequestDispatcher should allow interception of any call by custom request handler
| Reported by: | anonymous | Owned by: | Christian Boos |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11 |
| Component: | general | Version: | devel |
| Severity: | minor | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
RequestDispatcher always dispatches calls to default handler (WikiModule) when path_info == '/' even if custom IRequestHandler can handle some requests, which does not allow certain extensions like adding proper WebDAV access to attached files.
Very simple change could resolve this problem.
Proposed patch attached
Attachments (1)
Change History (5)
comment:1 by , 18 years ago
| Severity: | trivial → minor |
|---|
by , 18 years ago
| Attachment: | main.py.diff added |
|---|
comment:3 by , 18 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
Yes. Now what would have been perfect would have been something else than anonymous for the credits ;-)
comment:4 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Patch applied in r5688. Thanks!
Note:
See TracTickets
for help on using tickets.
Patch looks interesting, though IIUC the default handler would become a "catch all" handler rather than the handler for the "root" of the project. I'm not sure that change of behavior is desirable. By moving the check for '/' after the handler selection and reverting to the default handler only if the handler is still None and the path info is the root, your goal should be satisfied and the original behavior preserved.