Modify ↓
#5383 closed defect (fixed)
Akismet throws when marking something via monitoring
| Reported by: | Owned by: | Christian Boos | |
|---|---|---|---|
| Priority: | high | Milestone: | not applicable |
| Component: | plugin/spamfilter | Version: | devel |
| Severity: | critical | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
As author is None for anonymous users author.encode('utf-8') fails.
Patch + Traceback attached.
Attachments (2)
Change History (5)
by , 18 years ago
| Attachment: | trac-spamfilter-akismet-author.diff added |
|---|
by , 18 years ago
| Attachment: | trac-spamfilter-akismet-author-tb.log added |
|---|
comment:1 by , 18 years ago
| Milestone: | → not applicable |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:2 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed in r5517.
The API doc for FilterSystem.test(req, author, changes) specifies that:
author: the name of the logged in user, or 'anonymous' if the user is not logged in
Therefore the filters should be able to expect this as well. We simply ensure in FilterSystem.test that this will always be the case, and have an additional check in FilterSystem.train when fetching log entries saved before the fix.
comment:3 by , 18 years ago
Just got hit by this on t.e.o, can someone upgrade the spamfilter to the latest? Thanks.
Note:
See TracTickets
for help on using tickets.
The Akismet filter was the only filter making use of the author parameter, but the problem was more general, so I've fixed it in a different way than in the proposed patch.