Edgewall Software
Modify

Opened 17 years ago

Last modified 9 years ago

#5382 new enhancement

improve storage of binary content in the database

Reported by: Nils Maier <MaierMan@…> Owned by:
Priority: low Milestone: next-major-releases
Component: database backend Version: devel
Severity: normal Keywords: binary content
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

r5390/#4087 breaks compatibility with python2.3, as there doesn't seem to be a unicode.decode method.

Patch attached (don't know if this is the best solution though, but works for me at least).
Decoding content via str() should be safe (base64 ;)).

Attachments (1)

trac-spamfilter-b64decode.diff (602 bytes ) - added by Nils Maier <MaierMan@…> 17 years ago.
proposed patch, v1

Download all attachments as: .zip

Change History (21)

by Nils Maier <MaierMan@…>, 17 years ago

proposed patch, v1

comment:1 by Christian Boos, 17 years ago

Keywords: binary content added
Milestone: not applicable
Owner: changed from Matthew Good to Christian Boos
Severity: blockermajor

Thanks for the patch.

This code really starts to become scary ;-) We should really think about a better way to store binary content.

comment:2 by anonymous, 17 years ago

Resolution: fixed
Status: newclosed

comment:3 by Eli Carter, 17 years ago

Resolution: fixed
Status: closedreopened

This ticket should probably not be closed. Especially by anonymous without any explanation.

in reply to:  3 comment:4 by anonymous, 16 years ago

Owner: changed from Christian Boos to anonymous
Status: reopenednew

Replying to ecarter:

This ticket should probably not be closed. Especially by anonymous without any explanation.

comment:5 by Christian Boos, 16 years ago

Owner: changed from anonymous to Christian Boos

comment:6 by anonymous, 16 years ago

Resolution: fixed
Status: newclosed

comment:7 by osimons, 16 years ago

Resolution: fixed
Status: closedreopened

Please don't close as anonymous without explanation.

comment:9 by anonymous, 15 years ago

Type: defectenhancement

comment:10 by anonymous, 15 years ago

Owner: changed from Christian Boos to anonymous
Status: reopenednew

comment:11 by anonymous, 15 years ago

Severity: majornormal

comment:12 by anonymous, 15 years ago

Status: newassigned

comment:13 by anonymous, 15 years ago

Resolution: fixed
Status: assignedclosed

comment:14 by Emmanuel Blot, 15 years ago

Owner: changed from anonymous to Christian Boos

Edgwall.org really needs a custom workflow to prevent anonymous from randomly changing ticket status…

comment:15 by Emmanuel Blot, 15 years ago

Resolution: fixed
Status: closedreopened

comment:16 by anonymous, 15 years ago

Summary: base64 encoding/decoding breaks compatiblity with python2.3[PATCH] base64 encoding/decoding breaks compatiblity with python2.3

comment:17 by Christian Boos, 14 years ago

Component: plugin/spamfilterdatabase backend
Milestone: not applicablenext-major-0.1X
Summary: [PATCH] base64 encoding/decoding breaks compatiblity with python2.3improve storage of binary content in the database

Now it's a bit late to worry about Python 2.3 compatibility.

However, finding a better and backend neutral way to store binary content is still a goal.

comment:18 by Carsten Klein <carsten.klein@…>, 14 years ago

I wonder why one would want to improve on storing binary content in the database when there is actually no binary content is being stored in the backend?

I mean, all binary/text attachments to for example wiki pages and tickets are being stored in the filesystem?

And, if that is going to be changed, then I would propose that for both storing of and retrieval of binary content (aka blobs) to and fro the backend, a streaming interface should be used. See for example http://www.blobstreaming.org/, see also the referenced links to the right.

Besides that, str is now a replacement for the former unicode api, so there is actually no need to decode or encode it as unicode…

comment:19 by Remy Blank, 14 years ago

It seems that the SpamFilter plugin stores binary data in the database.

comment:20 by Christian Boos, 14 years ago

Priority: highestlow

No idea why this was "highest".

comment:21 by Ryan J Ollos, 9 years ago

Owner: Christian Boos removed
Status: reopenednew

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.