[PATCH] RequestDone not caught when raised from post request filter called due to error

[pacopablo]

OK, this is a small patch, but kind of hard to explain issue.

So, if an exception is raised, such at PermissionError, etc. The post request filters are run, which is as it should be. If however, a post request filter ends with a RequestDone exception, as is the case when one calls req.redirect() then the RequestDone exception isn't caught.

This causes a traceback to appear in the logs, and, for me, seems to slow down the response of the request (don't know why, so don't really know if it's possibly related ot something else).

However, I believe that raising RequestDone from said post request handler is valid, and thus shouldn't cause any exception to be shown in the log.

[pacopablo]

Patch for catching RequestDone exception in certain instances from post request filters

[Dave Abrahams <dave@…>]

Just want to add my strong vote for getting this into 0.11

The plugin that solves #5340 depends on this 2-line patch, so it would close 2 tickets with 2 lines and I could run a stock Trac 0.11 installation.

[Noah Kantrowitz]

Fixed in [5808]