Expand dir: sorting column resets the expanded tree

[Emmanuel Blot]

When a directory tree has been expanded, and the user select a column header to modify the sorting (for example, sort-by-age), the expanded tree is folded entirely.

[Christian Boos]

Yes, I know, but at this point, I have no intent to change this. This would be overly complex for no real benefit, as once you've changed the sorting order, it remains in use and will be used for all the expanded entries.

If someone wants to implement this however, patches are welcomed ;-)

[Christian Boos]

Just had an afterthought, here's an implementation idea:

• modify the sort links so that they call a "sortDir" method instead
• maintain a tree of all the fetched folders in the expand/close callbacks

In "sortDir(order)"

• prune the tree of fetched folders so that it contains only the opened folders
• remove all the rows
• fetch again all the folders, in top-down order

That solution admittedly puts some load on the server, but is simpler to implement than a smart in place sort that would essentially duplicate the sort logic in browser.py (with the additional complexity of having to reparse dates and sizes (0.8kB > 345 bytes!) and deal with the "logical" tree of folders…

[Christian Boos]

Actually a simpler solution would be to modify the sorting links, so that they contain the last expanded folder path.

Required change on top of #7074:

trac/htdocs/js/expand_dir.js

@@ -79 +79 @@
         .substr(window.location.pathname.length+1)
         .replace(/([^?]*)(\?.*)?$/, '$1');
 
+    // update sort links in column headers
+    tr.parents("table:first").find("thead tr:first").find("a").each(function(){
+      var href = $(this).attr("href").replace(/#.*$/, '');
+      $(this).attr("href", href+window.location.hash);
+     });
+
     if ( tr.hasClass("collapsed") ) { // then *expand*
       tr.removeClass("collapsed").addClass("expanded");
       tr.siblings("tr."+folderid).show();

[Christian Boos]

Was fixed in r7981.