Edgewall Software
Modify ↓

Opened 17 years ago

Closed 16 years ago

#5277 closed defect (fixed)

Expand dir feature: table width/height issue

Reported by: Emmanuel Blot Owned by: Christian Boos
Priority: normal Milestone: 0.11
Component: version control/browser Version: devel
Severity: minor Keywords: css
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

See attached snapshots:

When a folder is expanded or folded, the height of the related row is modified, which looks dirty.

Snapshots taken from WebKit, but I've been able to reproduce the same issue with Firefox 2.x. It really depends on the actual width of the browser window; anyway it seems to be a matter of telling the browser where to break a line when a full row does not fit in the browser window.

Attachments (2)

expand_dir_expand.png​ (10.9 KB ) - added by Emmanuel Blot 17 years ago.
simple height
expand_dir_fold.png​ (11.2 KB ) - added by Emmanuel Blot 17 years ago.
double height

Download all attachments as: .zip

Change History (9)

by Emmanuel Blot, 17 years ago

Attachment: expand_dir_expand.png​ added

simple height

by Emmanuel Blot, 17 years ago

Attachment: expand_dir_fold.png​ added

double height

comment:1 by Emmanuel Blot, 17 years ago

Component: general → browser
Owner: changed from Jonas Borgström to Christian Boos

comment:2 by Christian Boos, 17 years ago

Milestone: → 0.11
Status: new → assigned

Should be fixed in r5358, can you confirm?

comment:3 by Christian Boos, 17 years ago

Well, try r5362…

comment:4 by Emmanuel Blot, 17 years ago

Resolution: → fixed
Status: assigned → closed

Yeah, you've fixed it. Thanks.

comment:5 by Christian Boos, 16 years ago

Milestone: 0.11 → 0.11.1
Priority: low → normal
Resolution: fixed
Status: closed → reopened

The problem reappeared, need to have another look.

comment:6 by Christian Boos, 16 years ago

Keywords: css added

Things get slightly better with this change:

  • trac/htdocs/css/browser.css 

    diff -r ed4269932176 trac/htdocs/css/browser.css
    a b div.message {  
    7373 padding-left: 20px;
    7474}
    7575#dirlist td.name a.parent { background-image: url(../parent.png) }
     76#dirlist td.name div { white-space: pre }
    7677#dirlist tr span.expander {
    7778  background-image: url(../expander_normal.png);
    7879  cursor: pointer;

Works fine in IExplorer and Opera, but in Firefox it can lead to a small overlap on the size column for the cell which used to be wrapped (the "armimglib" folder in the attachment:expand_dir_fold.png​ sample).

If someone has a better fix, I'm all ears.

comment:7 by Christian Boos, 16 years ago

Milestone: 0.11.1 → 0.11
Resolution: → fixed
Severity: trivial → minor
Status: reopened → closed

Above fix committed as [6274].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.