Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

#5203 closed enhancement (fixed)

Configurable name in From header

Reported by: Noah Kantrowitz Owned by: Emmanuel Blot
Priority: normal Milestone: 0.11
Component: notification Version: devel
Severity: normal Keywords: olpc
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Attached is a patch to allow controlling the name portion of the From header in notifications.

Attachments (1)

olpc_from_name.diff (1.5 KB ) - added by Noah Kantrowitz 18 years ago.
Patch to add option for from name. (against r5255)

Download all attachments as: .zip

Change History (8)

by Noah Kantrowitz, 18 years ago

Attachment: olpc_from_name.diff added

Patch to add option for from name. (against r5255)

comment:1 by Emmanuel Blot, 18 years ago

Would it make sense to tweak the "Sender" SMTP header as well?

comment:2 by Noah Kantrowitz, 18 years ago

If am understanding RFC 822 correctly, I do not think so. It is supposed to be a "unique" (i.e. identifiable) indicator of the originator of the message. From is the only one that needs to have the human-readable niceness.

comment:3 by Emmanuel Blot, 18 years ago

It seems from RFC 2822 that in any case, the existing code is not compliant with SMTP:
If the originator of the message can be indicated by a single mailbox and the author and transmitter are identical, the "Sender:" field SHOULD NOT be used. Otherwise, both fields SHOULD appear.

from_email is used for both fields in the current implementation, and this is wrong.

Nevertheless I have not found a reference to the "human-readable niceness" thing. Would you have a section reference about this point? Sender and From seem to support the same mailbox definition, which may optionally include a display name (that is, the "niceness" thing).

comment:4 by Emmanuel Blot, 18 years ago

Status: newassigned

(Anyway I think this patch is useful)

in reply to:  4 comment:5 by Christian Boos, 18 years ago

Replying to eblot:

(Anyway I think this patch is useful)

Please pick up a milestone then.

comment:6 by Emmanuel Blot, 18 years ago

Milestone: 0.11

Low-risk patch, scheduled for 0.11

comment:7 by Emmanuel Blot, 18 years ago

Resolution: fixed
Status: assignedclosed

Patch applied in [5509]. Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Emmanuel Blot.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Emmanuel Blot to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.