Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

Last modified 10 years ago

#5195 closed defect (worksforme)

Revision number stored as text field

Reported by: anonymous Owned by: Jonas Borgström
Priority: normal Milestone:
Component: general Version: 0.10.3
Severity: normal Keywords: rev, text, field, postgresql
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When using the postgres backend, trac creates the 'rev' column in the 'revision' table as a text field. This is quite wrong. I'm not sure if there are similar mistakes in other tables since I did not check.

trac=# \d revision;
    Table "public.revision"
 Column  |  Type   | Modifiers
---------+---------+-----------
 rev     | text    | not null
 time    | integer |
 author  | text    |
 message | text    |

Attachments (0)

Change History (4)

comment:1 by Christian Boos, 18 years ago

Resolution: worksforme
Status: newclosed

This is by design. Trac support other VersioningSystemBackend than Subversion and the revision is not always a number.

comment:2 by anonymous, 18 years ago

Fair enough. Although it seems like it should only be set to text for backends that actually require it. For example, SVN never needs text as the revision is always a whole number.

comment:3 by Christian Boos, 18 years ago

Not even that, as you're free to keep an existing Trac environment and at any time change the repository_type and resync. Bye SVN, hello Darcs or some other fancy system ;-)

Ok, in theory you could drop the table and recreate it differently, but we don't do such things in general in Trac outside of the database schema upgrade process.

comment:4 by Ryan J Ollos, 10 years ago

Keywords: postgresql added; postgres removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.