bug when removing a filter

[Waldemar Kornewald <wkornewald>]

Add a few filters for "Component". Then click on "Update". Then, remove the topmost filter for "Component". The whole row is removed, including the label.

[Christian Boos]

Confirmed on 0.11, doesn't affect 0.10.

[osimons]

Looked into this, and turns out Firefox views the whitespace between the elements as the nextSibling element.

Using jQuery method instead seems to fix it:

trac/htdocs/js/query.js

@@ -27 +27 @@
       }
       if (mode && (getAncestorByTagName(mode, "tr") == tr)) {
         // Check whether there are more 'or' rows for this filter
-        var next = tr.nextSibling;
+        var next = $(tr).next()[0];
         if (next && (next.className == propertyName)) {
           function getChildElementAt(e, idx) {
             e = e.firstChild;

Javascript/jQuery is not my strongest side… Feedback appreciated :-)

[Christian Boos]

Seems you nailed it down - fix verified.

[osimons]

Fixed: Committed in [7284:7285] for 0.11 and trunk.