Web-Admin error with Trac milestones

[Paresh.Solanki@…]

The 'completed' flag is not read correctly when managing milestones through the Web Admin module.

To replicate this, select a milestone through the roadmap and edit it so that it is flagged as completed. The date and time are recorded at this point.

If you go back to edit from this view, then the milestone is still flagged as completed.

Now select the milestones from the admin menu. The first thing to note is that the completed milestone is not differentiated from the open ones in any way. Now, whenever you click on the completed milestone, the completed flag is clear.

If you happen to change something else, such as the comment, the milestone will be accidentally re-opened.

If you tick the completed box, the date and time closed are updated and will not be correct for the milestone.

So, I guess there are two related issues resulting from this:-

1. some way of differentiating active and completed milestones is required, either by colour or by having a column for the completed date.

2. This module needs to correctly read the completed flag and only update the date completed flag if it was clear and is being saved as completed. If it was completed and is being saved as completed, the completed date should not be updated.

[Christian Boos]

Sounds similar to #4948, but for the plugin. What version of the plugin are you using, exactly?

(if you're not using the plugin but 0.11dev, then point 2. has been solved)

For 1), I think we should visually distinguish closed milestone everywhere, in a similar way than we do for closed tickets, but maybe not exactly the same way, as strike-through style doesn't look that good for milestone names (italic?).

[Paresh.Solanki@…]

Yes, it looks like the same issue.

I am using Trac V0.10 and tracwebadmin 0.1.2dev-r4240 I make the code changes myself if I know what I'm looking for but I'm not yet a python coder yet, so I will need my hand held for now :)

I think that italics for closed milestones would be a good idea. Definitely do not strikethrough on milestones as that wouldn't look too nice.

[Christian Boos]

(associating the webadmin plugin fixes to 0.10.x)

[luchko@…]

This is the patch to fix the problem

[Mark Mc Mahon <mark.mcmahon@…>]

I would recommend this ticket be closed. Looking under Admin in 0.13 dev:

• There is a completed column
• Clicking on a completed milestone (and it is check correctly)

[Mark Mc Mahon <mark.m.mcmahon@…>]

Resolving as there no longer seems to be any issue, it seems to have been fixed sometime in the last 3 years.

[osimons]

Thanks for reviewing and helping out! Just changing to a technically more correct resolution. See TracTicketTriage for explanations.