Inversion of the Milestone completion status

[Emmanuel Blot]

The milestone "edit" page is in trouble:

When a milestone has been marked as "completed" and the milestone details are edited, the browser shows the "Completed" checkbox as unchecked.

This means that if the user does not reselect the "completed" state of the completed Milestone and save the changes, the milestone is marked as "not completed".

It seems the trouble comes for the JQuery javascript, as the XHTML code is correct: the checkbox XHTML of the edited, completed milestone contains checked="checked", but the browser does not reflect this initial state.

Note that the state is inverted: a milestone that is not completed and selected for edition exhibits a "completed" state.

Note also that the default activation of the checkbox is inverted with the state of the completion date: when the milestone edition page is loaded, if the "completed" checkbox is flagged, the "completion date" input is disabled, and vice-versa. Selecting the "completed" checkbox twice "fixes up" the issue.

This issue occurs on common browsers (IE6, Firefox 2.0.x, …)

[Christian Boos]

I've already fixed the same problem for the milestone admin panel (r4661), thought I "ported" the fix to the edit_milestone.html template as well, but apparently didn't…

[Christian Boos]

Fixed in a similar way than r4661, in r5074.