Edgewall Software
Modify

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#4964 closed enhancement (duplicate)

User filter for timeline

Reported by: yotamrubin@… Owned by: Christian Boos
Priority: low Milestone:
Component: timeline Version: 0.10.3.1
Severity: minor Keywords: user
Cc: Branch:
Release Notes:
API Changes:

Description

Hello there,

I've just added the capability to filter the timeline by username. The change should have been trivial, but apparently the Timeline is rather difficult to get into. The process_request function is quite large, and has a very complex namespace. I did some dumb refactoring - moved out logical blocks in process_request to their own functions, but the logic remains the same. Additionally, the way I added the user filter is rather ad-hoc, since the current filter mechanism is a boolean one, either it's enabled, or not. Maybe next weekend I'll work on improving the filter mechanism.

Attachments (2)

trac-with-userfilter.diff (6.4 KB ) - added by yotamrubin@… 13 years ago.
The userfilter patch
trac-with-userfilter-2.diff (2.7 KB ) - added by francois_at_granade.com 12 years ago.
The first patch attached to this bug was slightly buggy (it would break the other types of filters). This new patch doesn't break anything.

Download all attachments as: .zip

Change History (5)

by yotamrubin@…, 13 years ago

Attachment: trac-with-userfilter.diff added

The userfilter patch

comment:1 by Christian Boos, 13 years ago

Keywords: user added

Ouch, sorry, but this is never going to make it into Trac, as development of the 0.10-stable branch is for bug fixes only.

The trunk (Trac 0.11dev) is in heavy development since months, and the timeline module has changed a lot, though your points would still be valid with the new version of the code, see source:trunk/trac/timeline/web_ui.py. Look also at the new approach we started in e.g. r4970 for handling requests.

So it would be very much appreciated if you reworked your patch for the trunk. Also, be aware that the web templates are quite different now: see TracDev/PortingFromClearSilverToGenshi.

comment:2 by Christian Boos, 13 years ago

Milestone: 0.11
Resolution: duplicate
Status: newclosed

As #1198 was the original feature request, with already many people CC'ed there, I'm closing this one as duplicate.

in reply to:  1 comment:3 by anonymous, 13 years ago

Ok then. I've looked at the development version of trac. Seems like basic issues mentioned in my ticket appear in that version as well. I'll adapt my patch to the development version, and maybe resolve the filter issue as well.

Replying to cboos:

Ouch, sorry, but this is never going to make it into Trac, as development of the 0.10-stable branch is for bug fixes only.

The trunk (Trac 0.11dev) is in heavy development since months, and the timeline module has changed a lot, though your points would still be valid with the new version of the code, see source:trunk/trac/timeline/web_ui.py. Look also at the new approach we started in e.g. r4970 for handling requests.

So it would be very much appreciated if you reworked your patch for the trunk. Also, be aware that the web templates are quite different now: see TracDev/PortingFromClearSilverToGenshi.

by francois_at_granade.com, 12 years ago

Attachment: trac-with-userfilter-2.diff added

The first patch attached to this bug was slightly buggy (it would break the other types of filters). This new patch doesn't break anything.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.