Subversion blame support lacks helpful error

[Tim Hatch]

Just thought I'd report this. I'm using Debian and the latest python2.3-subversion is 1.2.3 which apparently is missing svn_opt_revision_value_t so when trying to view a blame you just get "HTML preview not available." Something similar was fixed in r4496 and r4523 but that's for when annotators fail, not the bindings themselves.

I wanted to document the traceback because I'm going to upgrade to Python 2.4 and Subversion 1.4.2 bindings which will (if all goes well) make this issue go away for me. I think a printed error (not blaming the previewer generically) should be more helpful since this is a configuration more people might be on.

2007-03-05 16:16:52,529 Trac[api] WARNING: HTML preview using <trac.mimeview.api.PlainTextRenderer object at 0xb5b0688c> failed ('module' object has no attribute 'svn_opt_revision_value_t')
Traceback (most recent call last):
  File "/usr/lib/python2.3/site-packages/Trac-0.11dev_r4935-py2.3.egg/trac/mimeview/api.py", line 500, in render
    m and Ranges(m))
  File "/usr/lib/python2.3/site-packages/Trac-0.11dev_r4935-py2.3.egg/trac/mimeview/api.py", line 535, in _render_source
    data = (annotator, annotator.get_annotation_data(context))
  File "/usr/lib/python2.3/site-packages/Trac-0.11dev_r4935-py2.3.egg/trac/versioncontrol/web_ui/browser.py", line 545, in get_annotation_data
    return BlameAnnotator(context)
  File "/usr/lib/python2.3/site-packages/Trac-0.11dev_r4935-py2.3.egg/trac/versioncontrol/web_ui/browser.py", line 562, in __init__
    self.reset()
  File "/usr/lib/python2.3/site-packages/Trac-0.11dev_r4935-py2.3.egg/trac/versioncontrol/web_ui/browser.py", line 568, in reset
    self.annotations = node.get_annotations()
  File "/usr/lib/python2.3/site-packages/Trac-0.11dev_r4935-py2.3.egg/trac/versioncontrol/svn_fs.py", line 747, in get_annotations
    rev = _svn_rev(self.rev)
  File "/usr/lib/python2.3/site-packages/Trac-0.11dev_r4935-py2.3.egg/trac/versioncontrol/svn_fs.py", line 123, in _svn_rev
    value = core.svn_opt_revision_value_t()
AttributeError: 'module' object has no attribute 'svn_opt_revision_value_t'

I'm not assigning it to "mimeview" or "annotate" or "subversion" because those components don't exist. Feel free to reassign if you feel another area is more appropriate.

[Christian Boos]

Ok. Besides, it would be interesting to know what is the exact requirement for the annotation support, I can't remember for sure if I tested it with 1.3.0…

[Christian Boos]

Should be fixed by r5232.