LOG_LIMIT -> runtime option?

[Sergei Haller <sergei@…>]

would it be possible to make LOG_LIMIT value in trac/versioncontrol/web_ui/log.py be configurable via conf/trac.ini

[Sergei Haller <sergei@…>]

maybe LOG_LIMIT is not the right thing. I actually think, that LOG_LIMIT can stay where it is.

The actual reequest is to make the default number of revisions displayed in the revision log browser to be configurable. (at the moment it is the same as LOG_LIMIT)

[Christian Boos]

IIRC, a "limit" parameter was originally part of the log preferences panel. Then, it was a bit redundant with the 'back to' parameter (in View log starting at ____ and back to ____).

Maybe this could be made a user configurable setting.

[Sergei Haller <sergei@…>]

ehm yea, that was also my first impression. correct is that LOG_LIMIT is the macimal number of revisions to whow in revlog viewer. That is, wven if you enter you want 10000 back to 1, it will at most show LOG_LIMIT revisions at a time.

on the other hand, the same value is used for the default display. (i.e. when you first click on "rev log" without having entered anything in this update dialog)

but that's not urgent, as I have changed the value in the source. Just thought would be a good idea to make that configurable via trac.ini.

[Sergei Haller <sergei@…>]

Replying to cboos:

IIRC, a "limit" parameter was originally part of the log preferences panel. Then, it was a bit redundant with the 'back to' parameter (in View log starting at ____ and back to ____).

voting to readd this (in 0.11?) again. It is not unusual to ask for revisions 10000 to 2 but showing at most 10 or 20 revisions (which might be e.g. 9001,9000,8992,6000,300,2 for a subdirectory or a single file)

attaching a patch.

[Sergei Haller <sergei@…>]

updated against svn r4781

[Sergei Haller <sergei@…>]

I just updated the patch. I'd really appreciate it if you could get it into the trunk.

I see that this is obviously redundant with the "back to" parameter, but only in the root of the svn project. In any subdirectory, or a particular file, these are really two different things.

Thanks in advance.

[Christian Boos]

I liked the formulation Show at most n revisions, as expressed that way it's not redundant neither ambiguous with the back to parameter (it's even clearer, because previously if one specified from 2000 and back to 1000, one would only get the first 100 revisions, without that limit being explicitly mentioned anywhere).

Slightly adapted patch applied in r4788, thanks!

[Sergei Haller <sergei@…>]

that adds an option to trac.ini to adjust the default value for limit

[Christian Boos]

What would you think about:

trac/versioncontrol/web_ui/log.py

@@ -19 +19 @@
 import re
 import urllib
 
+from trac.config import IntOption
 from trac.context import Context
 from trac.core import *
 from trac.perm import IPermissionRequestor
@@ -34 +35 @@
                             Chrome
 from trac.wiki import IWikiSyntaxProvider, WikiParser 
 
-LOG_LIMIT = 100
-
 class LogModule(Component):
 
     implements(INavigationContributor, IPermissionRequestor, IRequestHandler,
                IWikiSyntaxProvider)
 
+    default_log_limit = IntOption('revisionlog', 'default_log_limit', 100,
+        """Default value for the limit argument in the TracRevisionLog
+        (''since 0.11'').""")
+
     # INavigationContributor methods
 
     def get_active_navigation_item(self, req):
@@ -73 +76 @@
         revs = req.args.get('revs', rev)
         format = req.args.get('format')
         verbose = req.args.get('verbose')
-        limit = int(req.args.get('limit') or LOG_LIMIT)
+        limit = int(req.args.get('limit') or self.default_log_limit)
 
         repos = self.env.get_repository(req.authname)
         normpath = repos.normalize_path(path)

instead?

I think it's better to keep that in the same module, plus it makes it more convenient to use the value (by using self.default_log_limit).

[Sergei Haller <sergei@…>]

Replying to cboos:

What would you think about: ![…] instead?

I think it's better to keep that in the same module, plus ![…]

sure. would have done myself, but didn't feel like adding a new section to trac.ini

_{and of course I don't have as good overview over the code as you guys do}

[Christian Boos]

Ok, added in r4802.

[Sergei Haller <sergei@…>]

cool. thanks