#4747 closed defect (worksforme)
diff legend problems
Reported by: | Owned by: | Christian Boos | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | version control/changeset view | Version: | devel |
Severity: | minor | Keywords: | css |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
diff.css r4668 involved changing the last value of margin of .legend dt from 2em to 0 this causes diff legend only to contain the words "unchanged" and so on, but not the boxes with colors.
vote for changing it back to 2em (that helped here)
Attachments (0)
Change History (6)
comment:1 by , 18 years ago
comment:2 by , 18 years ago
Component: | general → changeset view |
---|---|
Keywords: | needinfo added; changeset removed |
Owner: | changed from | to
comment:3 by , 18 years ago
I changed the value back into 0 and it still works. I think I know what's going on:
I had the official trac 10.3 (installed as rpm) which for various reasons I replaced by the dev svn version (I did remove the 10.3 first, though, so the install was clean.)
for some reason the browser must have kept the 10.3's copy of diff.css in its cache. As I can't reproduce it, I don't know if this is the browsers fault (seamonkey) or tracd's.
sorry for troubling.
comment:4 by , 18 years ago
update: I was now able to reproduce the behaviour with a different css file.
as the old file (of 10.3) was sent to the browser by tracd, the expires header was set to a certain time in future. So the browser never bothered to ask for diff.css again. The reason, why changing 0 to 2em helped in my case, was that I pressed the reload button, after which the browser asked for each file again (and tracd correctly responded with either 200 or 304 depending on if the file was changed w.r.t. browsers cache or not)
so it is nobody but the users fault :)
comment:5 by , 18 years ago
Keywords: | needinfo removed |
---|---|
Resolution: | → worksforme |
Status: | new → closed |
Ok fine!
However I don't think there's an Expires header set by tracd for the diff.css (we send this header only after a redirect or an error, in both cases with 01 Jan 1999 for the date); it must have been something else. As you said you were able to reproduce it, can you provide us with the dump of the headers? (In Firefox, use LiveHTTPHeaders or the latest Firebug extension)
comment:6 by , 18 years ago
well. Don't have firefox here. using telnet, I get that:
# telnet host 8000 Trying 11.22.33.44... Connected to host. Escape character is '^]'. GET /proj/chrome/common/css/diff.css HTTP/1.1 Host: host HTTP/1.0 200 OK Server: tracd/0.11dev Python/2.4.4 Date: Fri, 16 Feb 2007 13:30:48 GMT Content-Type: text/css Content-Length: 4782 Last-Modified: Thu, 15 Feb 2007 12:03:37 GMT [...contents...]
which obviously didn't send the expires header back. Seamonkey though clearly states in "Page Info" dialog that the expiration date is 16.02. 16:02:44 GMT. But then again, I don't know what headers seamonkey sends when requesting…
Are you sure you don't have local customizations which are getting in the way?
See e.g. the Pocoo Trac, which uses a recent trunk (post-r4668).
Maybe try a quick fresh install, using tracd, and check if the problem is still there.