Edgewall Software
Modify

Opened 17 years ago

Closed 16 years ago

#4696 closed defect (fixed)

Customizing header logo size doesn't work

Reported by: matthias.waller@… Owned by: osimons
Priority: normal Milestone: 0.11
Component: general Version: devel
Severity: trivial Keywords: layout
Cc: kirean@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The width and height settings in trac.ini are noneffective.

Look in share/trac/templates/layout.html and add

width="${chrome.logo.width}" height="${chrome.logo.height}"

to the header image tag (~ line 39).

Attachments (0)

Change History (4)

comment:1 by Christian Boos, 17 years ago

Keywords: layout added
Milestone: 0.11
Severity: normaltrivial

Ok, IIRC, care must be taken to keep those value to None when not set (we used to have some hard-coded defaults), to be checked.

comment:2 by anonymous, 16 years ago

Cc: kirean@… added

comment:3 by osimons <simon-code@…>, 16 years ago

Milestone: 0.11.10.11
Owner: changed from Jonas Borgström to osimons

This works:

  • trac/templates/layout.html

     
    3939    <div id="banner">
    4040      <div id="header" py:choose="">
    4141        <a py:when="chrome.logo.src" id="logo" href="${chrome.logo.link}"><img
    42           src="${chrome.logo.src}" alt="${chrome.logo.alt}" /></a>
     42          src="${chrome.logo.src}" alt="${chrome.logo.alt}"
     43          height="${chrome.logo.height or None}" width="${chrome.logo.width or None}" /></a>
    4344        <h1 py:otherwise=""><a href="${chrome.logo.link}">${project.name}</a></h1>
    4445      </div>
    4546      <form py:if="'SEARCH_VIEW' in perm" id="search"

Setting values to 0 or -1 drops the attributes.

I can put it in if/when access is OK'ed.

comment:4 by osimons, 16 years ago

Resolution: fixed
Status: newclosed

Patch applied in [6225].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from osimons to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.