Modify ↓
Opened 18 years ago
Closed 17 years ago
#4696 closed defect (fixed)
Customizing header logo size doesn't work
Reported by: | Owned by: | osimons | |
---|---|---|---|
Priority: | normal | Milestone: | 0.11 |
Component: | general | Version: | devel |
Severity: | trivial | Keywords: | layout |
Cc: | kirean@… | Branch: | |
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
The width and height settings in trac.ini are noneffective.
Look in share/trac/templates/layout.html and add
width="${chrome.logo.width}" height="${chrome.logo.height}"
to the header image tag (~ line 39).
Attachments (0)
Change History (4)
comment:1 by , 18 years ago
Keywords: | layout added |
---|---|
Milestone: | → 0.11 |
Severity: | normal → trivial |
comment:2 by , 17 years ago
Cc: | added |
---|
comment:3 by , 17 years ago
Milestone: | 0.11.1 → 0.11 |
---|---|
Owner: | changed from | to
This works:
-
trac/templates/layout.html
39 39 <div id="banner"> 40 40 <div id="header" py:choose=""> 41 41 <a py:when="chrome.logo.src" id="logo" href="${chrome.logo.link}"><img 42 src="${chrome.logo.src}" alt="${chrome.logo.alt}" /></a> 42 src="${chrome.logo.src}" alt="${chrome.logo.alt}" 43 height="${chrome.logo.height or None}" width="${chrome.logo.width or None}" /></a> 43 44 <h1 py:otherwise=""><a href="${chrome.logo.link}">${project.name}</a></h1> 44 45 </div> 45 46 <form py:if="'SEARCH_VIEW' in perm" id="search"
Setting values to 0 or -1 drops the attributes.
I can put it in if/when access is OK'ed.
Note:
See TracTickets
for help on using tickets.
Ok, IIRC, care must be taken to keep those value to
None
when not set (we used to have some hard-coded defaults), to be checked.