Pdf files don't trigger "binary content" download message

[Tim Hatch]

The main mimeview renderer loop doesn't check to see if there are actually any acceptable renderers.

class PlainTextRenderer(Component):
...
     TREAT_AS_BINARY = [
        'application/pdf',
        'application/postscript',
        'application/rtf'
    ]

These make PlainTextRenderer return 0 for quality, so it's not used. PDF files under max_preview_size don't get the "download the file instead" link, and I wonder if we should add a new flag (checked in templates/macros.html, preview_file) for whether there is no preview because it was unclaimed binary data.

[Christian Boos]

Well, the download original content should always show up, no?

(I'm not saying it currently is, but that it really should).

[Christian Boos]

Ok, the:

Download in other formats:

Original Format

link is there… but now I guess you were talking of no explicit message appearing in the area where the preview should be. A reason like since no preview renderer could handle it instead of since the file size exceeds 262144 bytes. should be adequate, I think.

[Tim Hatch]

Yeah, that's it. There's an inconsistency between a .bin file of say 96k vs a .pdf file of 96k. I'd think they would both offer there "no preview; download instead" box. I like your "no preview available" as opposed to "is binary" now that I think about it.

[Christian Boos]

Fixed in r4708, feel free to tweak the message if you want (<insert the usual I'm not a native speaker disclaimer here> ;-) ).