Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#4672 closed defect (fixed)

empty svn:externals break trac browser

Reported by: Armin Ronacher Owned by: Christian Boos
Priority: high Milestone: 0.11
Component: version control/browser Version: devel
Severity: normal Keywords: svn:externals
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

How to Reproduce

Define svn:externals but keep them empty.

System Information

Trac 0.11dev
Python 2.4.3 (#2, Oct 6 2006, 07:49:22)
[GCC 4.0.3 (Ubuntu 4.0.3-1ubuntu5)]
SQLite 3.2.8
pysqlite 2.0.5
Genshi 0.4dev-r493
Pygments 0.7
Subversion 1.3.1

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 401, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 213, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/browser.py", line 326, in process_request
    node.get_properties()),
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/browser.py", line 468, in render_properties
    return filter(None, [self.render_property(name, mode, context, props)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/browser.py", line 480, in render_property
    rendered = renderer.render_property(name, mode, context, props)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/svn_fs.py", line 332, in render_property
    return self._render_externals(props[name])
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/svn_fs.py", line 347, in _render_externals
    localpath, rev, url = elements[0], None, elements[-1]
IndexError: list index out of range

Attachments (0)

Change History (3)

comment:1 by Christian Boos, 18 years ago

Milestone: 0.11
Status: newassigned

Define svn:externals but keep them empty.

Why on earth would you do that ;)

Ok, I didn't think about that, will fix.

comment:2 by Christian Boos, 18 years ago

Keywords: svn:externals added
Resolution: fixed
Severity: criticalnormal
Status: assignedclosed

Fixed by r4689.

in reply to:  1 comment:3 by Armin Ronacher, 18 years ago

Replying to cboos:

Define svn:externals but keep them empty.

Why on earth would you do that ;)

Obviously because someone was unable to use svn propdel :D

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.