Inconsistent treatment of underscores in Wiki Page Names

[Dave Matthews]

With Trac 0.8 there was a problem that _FooBar got treated as a wiki page name (see #957, #1317). This got fixed in 0.9. However, there seems to have been a further change in 0.10 such that FooBar_ now matches when it, presumably, shouldn't?

[Christian Boos]

Probably it shouldn't.

What about this change?

trac/wiki/api.py

@@ -284 +289 @@
             (upper, lower, upper, lower, lower) +
             r"(?:@\d+)?" # optional version
             r"(?:#%s)?" % self.XML_NAME + # optional fragment id
-            r"(?=:(?:\Z|\s)|[^:a-zA-Z]|\s|\Z)" # what should follow it
+            r"(?=:(?:\Z|\s)|[^:\w]|\s|\Z)" # what should follow it
             )
 
         def check_unicode_camelcase(pagename):

This would prevent FooBar3 to be recognized as a WikiPageName as well.

[Christian Boos]

FooBar_ is not part of the valid WikiPageNames anymore, so this must have been fixed at some point.

[David Matthews]

For some reason, this problem seems to have come back again. The following both show up as page links although I don't think they should: FooBar3, FooBar_

[Christian Boos]

Thanks for letting us know!

[Christian Boos]

So initially r4126 broke it… and it seems it never worked since so I wonder what I tested in comment:2…

Fixed for real now by r9984.

[David Matthews]

Great - yet another reason for us to upgrade to Trac 0.12!

Thanks.